[wpt-sync] Sync PR 62395 - [line-clamp] In displaced ellipses, only root inlines have a strut
Categories
(Core :: Layout: Scrolling and Overflow, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62395 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62395
Details from upstream follow.
Andreu Botella <abotella@igalia.com> wrote:
[line-clamp] In displaced ellipses, only root inlines have a strut
Line-clamp ellipses behave as if they had
line-height: 0, so they
never grow the line they're added to. However, when the ellipsis
displaces a whole line, to avoid that line having zero size, the root
inline box has a strut (i.e. it adds a corresponding height to the
line), but other open inline boxes don't.In our implementation of displaced ellipses, however, we were
triggering strict line height, meaning that all struts corresponding
to open inline boxes had a strut. Instead, this CL changes the
line_height_quirkboolean argument of
InlineLayoutStateStack::OnBeginPlaceItemsto aLineHeightModeenum
with a variant for the line-clamp displaced ellipsis, which behaves
like the line-height quirk (not adding struts) except for the root
inline box.Bug: 40336192, 543375422
Change-Id: Ie57e81086826032d6301c8bb4931b0e31ec565a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8287666
Commit-Queue: Andreu Botella \<abotella@igalia.com>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1690876}
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b10a90d259a984e9270d570189630c2e5da64b9
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 276 tests
Status Summary
Firefox
PASS: 7[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 139[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 140[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 1[GitHub] 136[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 137[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
FAIL: 1
Safari
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-overflow/line-clamp/block-ellipsis-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-005.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-006.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-012.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-013.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-014.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-015.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-016.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-017.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-018.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-019.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-020.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-021.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-025.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-027.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-028.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-029.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-030.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-032.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-033.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-035.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-036.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-037.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-039.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-overflow/line-clamp/block-ellipsis-040.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-041.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-bidi-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-bidi-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-bidi-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-quirk-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-quirk-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-repaint-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/continue-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/discard/discard-multicol-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/discard/discard-multicol-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/discard/discard-multicol-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/discard/discard-multicol-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-021.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-023.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-024.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-025.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-036.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-041.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-002.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-003.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-005.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-009.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-011.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-013.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-014.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-015.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-016.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-017.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-018.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-019.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-020.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-021.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-022.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-023.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-024.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-025.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-027.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-028.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-029.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-030.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-031.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-032.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-033.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-034.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-035.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-036.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-037.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-038.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-039.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-040.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-041.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-042.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-043.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-044.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-045.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-046.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-047.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-with-ruby-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-with-ruby-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-with-ruby-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-with-ruby-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-with-ruby-005.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-005.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-006.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-010.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-011.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-012.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-013.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-014.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-016.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-017.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-019.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-020.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-021.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-023.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-013.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-014.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-015.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-016.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-005.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-006.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-010.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-011.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-012.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-text-overflow-string-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-024.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-036.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-037.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-043.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-048.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-049.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/css-overflow/line-clamp/webkit-line-clamp-051.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-052.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-053.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-abspos-001.html [wpt.fyi]:
FAIL
Comment 4•2 months ago
|
||
| bugherder | ||
Description
•