Closed Bug 2068977 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62395 - [line-clamp] In displaced ellipses, only root inlines have a strut

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62395 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62395
Details from upstream follow.

Andreu Botella <abotella@igalia.com> wrote:

[line-clamp] In displaced ellipses, only root inlines have a strut

Line-clamp ellipses behave as if they had line-height: 0, so they
never grow the line they're added to. However, when the ellipsis
displaces a whole line, to avoid that line having zero size, the root
inline box has a strut (i.e. it adds a corresponding height to the
line), but other open inline boxes don't.

In our implementation of displaced ellipses, however, we were
triggering strict line height, meaning that all struts corresponding
to open inline boxes had a strut. Instead, this CL changes the
line_height_quirk boolean argument of
InlineLayoutStateStack::OnBeginPlaceItems to a LineHeightMode enum
with a variant for the line-clamp displaced ellipsis, which behaves
like the line-height quirk (not adding struts) except for the root
inline box.

Bug: 40336192, 543375422
Change-Id: Ie57e81086826032d6301c8bb4931b0e31ec565a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8287666
Commit-Queue: Andreu Botella \<abotella@igalia.com>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1690876}

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 276 tests

Status Summary

Firefox

PASS: 7[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 139[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 140[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 1[GitHub] 136[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 137[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/221858dc6c74 https://hg.mozilla.org/integration/autoland/rev/16cd99a5a0b5 [wpt PR 62395] - [line-clamp] In displaced ellipses, only root inlines have a strut, a=testonly
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.