[PDF.js] Begin Packaging Annotation Editor CSS and Add new CSS
Categories
(GeckoView :: PDF Viewer, task)
Tracking
(Not tracked)
People
(Reporter: olivia, Assigned: calixte)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fxdroid][group6])
Attachments
(2 external files)
We need to have PDF.js setup to bring in the annotation_editor_layer_builder.css .
Updated•2 months ago
|
| Reporter | ||
Comment 1•2 months ago
|
||
Scope might need to increase on this, I suspect some of the css we bring in is inapplicable to GV, since I see toolbar CSS as well.
Comment 2•2 months ago
|
||
| Reporter | ||
Comment 3•1 month ago
|
||
Rescoping this to include adding new CSS and just not enabling the old. It seems like it would be easier to do and review if in one bug together. Closing bug 2061836, since this will now have that scope.
| Reporter | ||
Comment 4•1 month ago
|
||
Hi Calixte,
If you have capacity for enabling and adding the CSS, your expertise would be much appreciated here! I can also pick this back up if you can provide me with some more guidance on how we can make this more maintainable for Desktop / Android differences.
The requirements I've been given are:
- Figma Designs here: https://www.figma.com/design/ppIRLQw1AAIeyaG7lwnn4R/PDF.js--Android-UI--Copy-?node-id=4157-25361&m=dev
- I had a pretty good stab at the implementation from a design perspective here: https://github.com/mozilla/pdf.js/pull/21936 (The padding between the bounding box and the signature could be better, but it is in the right ballpark design wise. Like you mentioned, it needs some thought on how to share the CSS better. I think there are also edge cases I'm not accounting for.)
- We'd like old annotations to not reactivate and keep it extremely minimal for this version so we don't have to support the extended toolbar just yet.
Anyway, please let me know what your thoughts are!
| Assignee | ||
Updated•1 month ago
|
Comment 6•1 month ago
|
||
(via GitHub webhook, authenticated as shared-secret)
| Reporter | ||
Comment 7•26 days ago
|
||
Merging into MC via bug 2085946.
Updated•26 days ago
|
Description
•