Closed Bug 2068989 Opened 2 months ago Closed 26 days ago

[PDF.js] Begin Packaging Annotation Editor CSS and Add new CSS

Categories

(GeckoView :: PDF Viewer, task)

All
Android
task
Points:
5

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: olivia, Assigned: calixte)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxdroid][group6])

Attachments

(2 external files)

We need to have PDF.js setup to bring in the annotation_editor_layer_builder.css .

Scope might need to increase on this, I suspect some of the css we bring in is inapplicable to GV, since I see toolbar CSS as well.

Blocks: 2069045

Rescoping this to include adding new CSS and just not enabling the old. It seems like it would be easier to do and review if in one bug together. Closing bug 2061836, since this will now have that scope.

See Also: → 2061836
Summary: [PDF.js] Begin Packaging Annotation Editor CSS → [PDF.js] Begin Packaging Annotation Editor CSS and Add new CSS

Hi Calixte,

If you have capacity for enabling and adding the CSS, your expertise would be much appreciated here! I can also pick this back up if you can provide me with some more guidance on how we can make this more maintainable for Desktop / Android differences.

The requirements I've been given are:

Anyway, please let me know what your thoughts are!

Assignee: ohall → nobody
Flags: needinfo?(cdenizet)

Thanks for taking this one!

Assignee: nobody → cdenizet
Flags: needinfo?(cdenizet)
Blocks: 2083699
Blocks: 2063416

Merging into MC via bug 2085946.

Status: NEW → RESOLVED
Points: 2 → 5
Closed: 26 days ago
Resolution: --- → FIXED
See Also: → 2085946
Depends on: 2085946
See Also: 2085946 →
Depends on: 2085971
No longer depends on: 2085971
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: