Closed Bug 2069018 Opened 2 months ago Closed 2 months ago

[customizable-menu] Basic integration in Fenix

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: petru, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(3 external files)

Needed:

  • a new secret setting - "Use customizable menu"
  • using the new secret setting to open a new bottom sheet instead of the current one used for the home and browser menus
  • a new MenuStore instantiated in the new BottomSheetDialogFragment
  • the new BottomSheetDialogFragment displaying a Menu with an empty list of items (for now).

*Note: Having the MenuStore as a singleton which would only parse the menu structure to build the configuration that will be displayed only once is an idea we might try pursuing but maybe only when we are closer to the final structure of the MenuStore and its middlewares in Fenix.
At the moment I'm unsure if we will be able to have the MenuStore live in components or even be tied to just the activity as it will be shared between the home/browser/custom tab menus which are different + its middleware will need a lot of dependencies, possibly some tied to the fragment.

Whiteboard: [fxdroid][android-core]
Assignee: nobody → petru
Status: NEW → ASSIGNED

Initially this will only support the browser menu.

Basic support. No UI or functionality yet.

Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d989a1ad0008 https://hg.mozilla.org/integration/autoland/rev/2587f947045d part 1 - New "Enable menu customization" secret setting r=android-reviewers,matt-tighe https://github.com/mozilla-firefox/firefox/commit/490fc9e34b46 https://hg.mozilla.org/integration/autoland/rev/fce46f5f7f32 part 2 - New MenuFragment to host the customizable menu r=android-reviewers,matt-tighe https://github.com/mozilla-firefox/firefox/commit/b91a2026d677 https://hg.mozilla.org/integration/autoland/rev/f225e3a2bb4c part 3 - Basic integration of compose-menu in Fenix r=android-reviewers,matt-tighe
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
See Also: → 2081681
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: