[customizable-menu] Basic integration in Fenix
Categories
(Firefox for Android :: Menu, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: petru, Assigned: petru)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][android-core])
Attachments
(3 external files)
Needed:
- a new secret setting - "Use customizable menu"
- using the new secret setting to open a new bottom sheet instead of the current one used for the home and browser menus
- a new
MenuStoreinstantiated in the new BottomSheetDialogFragment - the new BottomSheetDialogFragment displaying a
Menuwith an empty list of items (for now).
*Note: Having the MenuStore as a singleton which would only parse the menu structure to build the configuration that will be displayed only once is an idea we might try pursuing but maybe only when we are closer to the final structure of the MenuStore and its middlewares in Fenix.
At the moment I'm unsure if we will be able to have the MenuStore live in components or even be tied to just the activity as it will be shared between the home/browser/custom tab menus which are different + its middleware will need a lot of dependencies, possibly some tied to the fragment.
| Assignee | ||
Updated•2 months ago
|
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Available only in debug for now.
| Assignee | ||
Comment 2•2 months ago
|
||
Initially this will only support the browser menu.
| Assignee | ||
Comment 3•2 months ago
|
||
Basic support. No UI or functionality yet.
Comment 5•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2587f947045d
https://hg.mozilla.org/mozilla-central/rev/fce46f5f7f32
https://hg.mozilla.org/mozilla-central/rev/f225e3a2bb4c
Description
•