Closed Bug 2069243 Opened 2 months ago Closed 1 day ago

Move the storage layer into application-services

Categories

(Firefox :: Containers, task)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Keywords: perf-alert)

Attachments

(4 external files)

In order to support containers on mobile, we must share the underlying storage layer between Desktop and Android. This is the first task.

To summarize the effort:

  • create a Rust crate to manage the container data struct
  • this crate must support existing serialization format and the migrations from previous versions
  • the actual I/O is up to the caller via callbacks
Status: NEW → RESOLVED
Closed: 1 month ago
Flags: qe-verify+
Resolution: --- → FIXED
Assignee: nobody → amarchesini

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Pushed by amarchesini@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a9e671c6d061 https://hg.mozilla.org/integration/autoland/rev/5acc961806c0 Move Container Storage Layer into A-S - part 1 - Add migration tests r=timhuang https://github.com/mozilla-firefox/firefox/commit/d399140d596e https://hg.mozilla.org/integration/autoland/rev/641005d2174f Move Container Storage Layer into A-S - part 2 - ContextualIdentityService r=timhuang
Pushed by imoraru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d6455fc075b6 https://hg.mozilla.org/integration/autoland/rev/15119fd88308 Revert "Bug 2069243 - Move Container Storage Layer into A-S - part 2 - ContextualIdentityService r=timhuang" for causing xpcshell failures on test_siteAssociations.js.

Revert for causing xpcshell failures on test_siteAssociations.js. and also gv-junit failures like this , wpt failures like this and Gtest failures like this.

Flags: needinfo?(amarchesini)
Depends on: 2082524
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b31606db70dc https://hg.mozilla.org/integration/autoland/rev/c682e175a06c Move Container Storage Layer into A-S - part 1 - Add migration tests r=timhuang https://github.com/mozilla-firefox/firefox/commit/fa44e88ca642 https://hg.mozilla.org/integration/autoland/rev/65bc5ed734ec Move Container Storage Layer into A-S - part 2 - ContextualIdentityService r=timhuang
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e76294fcb123 https://hg.mozilla.org/integration/autoland/rev/a8e159c7daa9 Revert "Bug 2069243 - Move Container Storage Layer into A-S - part 2 - ContextualIdentityService r=timhuang" for causing xpc failures.

Backed out for causing xpc failures.

Flags: needinfo?(amarchesini)
Attachment #9648227 - Attachment description: Bug 2069243 - Move Container Storage Layer into A-S - part 1 - Add migration tests → Bug 2069243 - Move Container Storage Layer into A-S - part 3 - Add migration tests
Attachment #9648228 - Attachment description: Bug 2069243 - Move Container Storage Layer into A-S - part 2 - ContextualIdentityService → Bug 2069243 - Move Container Storage Layer into A-S - part 4 - ContextualIdentityService
Attachment #9684026 - Attachment description: Bug 2069243 - Move Container Storage Layer into A-S - part 0 - Enable UniFFI-JS for fxcontainers on Android, r?bdk → Bug 2069243 - Move Container Storage Layer into A-S - part 1 - Enable UniFFI-JS for fxcontainers on Android, r?bdk
Attachment #9684027 - Attachment description: Bug 2069243 - Move Container Storage Layer into A-S - part 1 - mach uniffi generate → Bug 2069243 - Move Container Storage Layer into A-S - part 2 - mach uniffi generate
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/15570f1f5c90 https://hg.mozilla.org/integration/autoland/rev/4fc61d609a73 Move Container Storage Layer into A-S - part 1 - Enable UniFFI-JS for fxcontainers on Android, r=bdk https://github.com/mozilla-firefox/firefox/commit/4e556616af43 https://hg.mozilla.org/integration/autoland/rev/0b39ca80e94d Move Container Storage Layer into A-S - part 2 - mach uniffi generate r=bdk https://github.com/mozilla-firefox/firefox/commit/96b7a91d820a https://hg.mozilla.org/integration/autoland/rev/fd5f965f03ad Move Container Storage Layer into A-S - part 3 - Add migration tests r=timhuang https://github.com/mozilla-firefox/firefox/commit/377a28204606 https://hg.mozilla.org/integration/autoland/rev/cc2472bdaeb1 Move Container Storage Layer into A-S - part 4 - ContextualIdentityService r=timhuang
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6b31a19cdf0d https://hg.mozilla.org/integration/autoland/rev/e50dee01dfbd Revert "Bug 2069243 - Move Container Storage Layer into A-S - part 4 - ContextualIdentityService r=timhuang" for causing failures at browser_UserContextManager.js.
Status: RESOLVED → REOPENED
Flags: needinfo?(amarchesini)
Keywords: leave-open
Resolution: FIXED → ---
Pushed by amarchesini@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8a0f982f9e4d https://hg.mozilla.org/integration/autoland/rev/988162fb3c53 Move Container Storage Layer into A-S - part 1 - Enable UniFFI-JS for fxcontainers on Android, r=bdk https://github.com/mozilla-firefox/firefox/commit/8cd3db740e1b https://hg.mozilla.org/integration/autoland/rev/b33514fa2c0a Move Container Storage Layer into A-S - part 2 - mach uniffi generate r=bdk
Keywords: leave-open
Pushed by amarchesini@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9dedd78c054e https://hg.mozilla.org/integration/autoland/rev/aec06ee2607d Move Container Storage Layer into A-S - part 3 - Add migration tests r=timhuang https://github.com/mozilla-firefox/firefox/commit/12042e42dd6c https://hg.mozilla.org/integration/autoland/rev/bc8174c44951 Move Container Storage Layer into A-S - part 4 - ContextualIdentityService r=timhuang,webdriver-reviewers,jdescottes
Status: REOPENED → RESOLVED
Closed: 1 month ago → 1 day ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch

Perfherder has detected a talos performance change from push b33514fa2c0a7a0c0e961340cd1e8fb6692c731f.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
63% perf_reftest style-sharing-style-attr.html (doc) macosx1500-aarch64-shippable e10s fission stylo webrender 0.53 ms -> 0.20 ms
38% perf_reftest stop-cascade-2.html (doc) linux2404-64-shippable e10s fission stylo webrender-sw 1.20 ms -> 0.74 ms
33% perf_reftest stop-cascade-1.html (doc) linux2404-64-shippable e10s fission stylo webrender-sw 1.15 ms -> 0.77 ms

Need Help or Information?

If you have any questions, please reach out to acseh@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: