Closed Bug 2069298 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62379 - WebGL: Add drawingBufferToneMapping interface

Categories

(Core :: Graphics: CanvasWebGL, task, P4)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62379 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62379
Details from upstream follow.

Christopher Cameron <ccameron@google.com> wrote:

WebGL: Add drawingBufferToneMapping interface

Implement the WebGL drawingBufferToneMapping interface, gated on the
experimental WebGLToneMapping runtime feature flag.

The feature is described at:
https://github.com/w3c-cg/ColorWeb-CG/blob/main/webgl-drawing-buffer-tone-map.md

It is a part of the larger HDR proposal at:
https://github.com/w3c-cg/ColorWeb-CG/blob/main/hdr-big-picture.md

The function is a combined getter-setter (takes an optional
CanvasToneMapping argument, returns the state).

The function is expected to destroy the color buffer's contents. This
may not be strictly necessary, but mirrors the capabilities in WebGPU,
and the behavior of setting the drawingBufferColorSpace attribute. Add a
test for this (mirroring the color space test).

Add WPT test external/wpt/webgl/drawingBufferToneMapping.html and update
webexposed global interface expectations.

TAG=agy
CONV=9f2c857b-3ae8-4048-ab49-db1109f50272

Bug: 555806830
Change-Id: If5908fcb910ee110a949b47663d905e526ca53e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8330328
Reviewed-by: Philip Jägenstedt \<foolip@chromium.org>
Commit-Queue: ccameron chromium \<ccameron@chromium.org>
Reviewed-by: Kai Ninomiya \<kainino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1690875}

Component: web-platform-tests → Graphics: WebGPU
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
FAIL: 8

Safari

OK : 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Component: Graphics: WebGPU → Graphics: CanvasWebGL
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.