[wpt-sync] Sync PR 62379 - WebGL: Add drawingBufferToneMapping interface
Categories
(Core :: Graphics: CanvasWebGL, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62379 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62379
Details from upstream follow.
Christopher Cameron <ccameron@google.com> wrote:
WebGL: Add drawingBufferToneMapping interface
Implement the WebGL drawingBufferToneMapping interface, gated on the
experimental WebGLToneMapping runtime feature flag.The feature is described at:
https://github.com/w3c-cg/ColorWeb-CG/blob/main/webgl-drawing-buffer-tone-map.mdIt is a part of the larger HDR proposal at:
https://github.com/w3c-cg/ColorWeb-CG/blob/main/hdr-big-picture.mdThe function is a combined getter-setter (takes an optional
CanvasToneMapping argument, returns the state).The function is expected to destroy the color buffer's contents. This
may not be strictly necessary, but mirrors the capabilities in WebGPU,
and the behavior of setting the drawingBufferColorSpace attribute. Add a
test for this (mirroring the color space test).Add WPT test external/wpt/webgl/drawingBufferToneMapping.html and update
webexposed global interface expectations.TAG=agy
CONV=9f2c857b-3ae8-4048-ab49-db1109f50272Bug: 555806830
Change-Id: If5908fcb910ee110a949b47663d905e526ca53e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8330328
Reviewed-by: Philip Jägenstedt \<foolip@chromium.org>
Commit-Queue: ccameron chromium \<ccameron@chromium.org>
Reviewed-by: Kai Ninomiya \<kainino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1690875}
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=abb23f701705b922385ec48f210bbebcd351e1e4
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 11 tests
Status Summary
Firefox
OK : 1
FAIL: 8
Chrome
OK : 1
FAIL: 8
Safari
OK : 1
FAIL: 8
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /webgl/basic-unused-context-crash.html [wpt.fyi]:
SKIP - /webgl/bufferSubData.html [wpt.fyi]:
SKIP - /webgl/compressed-tex-sub-image-2d-without-base-image.html [wpt.fyi]:
SKIP - /webgl/compressedTexImage2D.html [wpt.fyi]:
SKIP - /webgl/compressedTexSubImage2D.html [wpt.fyi]:
SKIP - /webgl/drawingBufferToneMapping.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] (Chrome:OK, Safari:OK)- webgl: interface presence:
FAIL(Chrome:FAIL, Safari:FAIL) - webgl: default value is standard:
FAIL(Chrome:FAIL, Safari:FAIL) - webgl: setting and getting modes:
FAIL(Chrome:FAIL, Safari:FAIL) - webgl: invalid mode throws TypeError:
FAIL(Chrome:FAIL, Safari:FAIL) - webgl2: interface presence:
FAIL(Chrome:FAIL, Safari:FAIL) - webgl2: default value is standard:
FAIL(Chrome:FAIL, Safari:FAIL) - webgl2: setting and getting modes:
FAIL(Chrome:FAIL, Safari:FAIL) - webgl2: invalid mode throws TypeError:
FAIL(Chrome:FAIL, Safari:FAIL)
- webgl: interface presence:
- /webgl/idlharness.any.html [wpt.fyi]:
SKIP - /webgl/idlharness.any.worker.html [wpt.fyi]:
SKIP - /webgl/texImage2D.html [wpt.fyi]:
SKIP - /webgl/texSubImage2D.html [wpt.fyi]:
SKIP - /webgl/uniformMatrixNfv.html [wpt.fyi]:
SKIP
Tests Disabled in Gecko Infrastructure
- /webgl/basic-unused-context-crash.html [wpt.fyi]:
SKIP - /webgl/bufferSubData.html [wpt.fyi]:
SKIP - /webgl/compressed-tex-sub-image-2d-without-base-image.html [wpt.fyi]:
SKIP - /webgl/compressedTexImage2D.html [wpt.fyi]:
SKIP - /webgl/compressedTexSubImage2D.html [wpt.fyi]:
SKIP - /webgl/drawingBufferToneMapping.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] (Chrome:OK, Safari:OK) - /webgl/idlharness.any.html [wpt.fyi]:
SKIP - /webgl/idlharness.any.worker.html [wpt.fyi]:
SKIP - /webgl/texImage2D.html [wpt.fyi]:
SKIP - /webgl/texSubImage2D.html [wpt.fyi]:
SKIP - /webgl/uniformMatrixNfv.html [wpt.fyi]:
SKIP
Updated•2 months ago
|
Comment 4•2 months ago
|
||
| bugherder | ||
Description
•