[wpt-sync] Sync PR 62422 - ruby: Propagate block-end annotation space in multicol containers
Categories
(Core :: Layout: Ruby, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62422 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62422
Details from upstream follow.
Kent Tamura <tkent@chromium.org> wrote:
ruby: Propagate block-end annotation space in multicol containers
Previously, block-end annotation space propagation was disabled for
children of balanced multicol containers to avoid issues in an existing
WPT test about column balancing. This CL enables it.This CL fixes BlockLayoutAlgorithm::FinishLayout() so that to compute
the available annotation space correctly for fragmented containers.Bug: 445727139, 538260158
Change-Id: I27848eba96cb7f8ae8eb775d725455e0bc8d8748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8294040
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Auto-Submit: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1691451}
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=95b77434f05396e910e0ea6d61795467eb81e266
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 177 tests and 6 subtests
Status Summary
Firefox
OK : 1[GitHub] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2[GitHub] 13[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 88[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 185[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 1[GitHub] 15[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 61[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
OK : 1
PASS: 2
FAIL: 1
Safari
OK : 1
FAIL: 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-ruby/collapse-trailing-whitespace.html [wpt.fyi]:
FAIL - /css/css-ruby/pseudo-first-line.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-annotation-with-margin.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-box-model-001.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-dynamic.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-none.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-001.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-002.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-003.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-004.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-005.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-006.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-007.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-008.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-009.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-010.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-011.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-012.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-013.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-014.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-015.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-016.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-017.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-018.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-019.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-021.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-align-001.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-align-002.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-align-003.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-align-004.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-align-005.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-non-bmp-001.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-non-bmp-002.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-text-spacing-trim-001.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-text-spacing-trim-002.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-vertical-001.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-vertical-002.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-vertical-003.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-vertical-004.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-overhang-spaces-vertical-005.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-tab-in-base-001.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-tab-in-base-002.html [wpt.fyi]:
FAIL - /css/css-ruby/ruby-tab-in-base-003.html [wpt.fyi]:
FAIL - /css/css-ruby/break-within-bases/basic.html [wpt.fyi]:
FAIL - /css/css-ruby/break-within-bases/no-break-opportunity-at-end.html [wpt.fyi]:
FAIL - /css/css-ruby/break-within-bases/nowrap.html [wpt.fyi]:
FAIL - /css/css-ruby/br-clear-all-002.html [wpt.fyi]
- #container 1:
FAIL
- #container 1:
- /css/css-ruby/inheritance.html [wpt.fyi]
- Property ruby-merge has initial value separate:
FAIL - Property ruby-merge inherits:
FAIL - Property ruby-overhang has initial value auto:
FAIL - Property ruby-overhang inherits:
FAIL
- Property ruby-merge has initial value separate:
- /css/css-ruby/parsing/ruby-merge-valid.html [wpt.fyi]
- e.style['ruby-merge'] = "separate" should set the property value:
FAIL - e.style['ruby-merge'] = "merge" should set the property value:
FAIL - e.style['ruby-merge'] = "auto" should set the property value:
FAIL
- e.style['ruby-merge'] = "separate" should set the property value:
- /css/css-ruby/line-spacing-on-edges.tentative.html [wpt.fyi]
- Line-over ruby on the first line: <rt> box top is above the block container top:
FAIL(Chrome:PASS, Safari:FAIL)
- Line-over ruby on the first line: <rt> box top is above the block container top:
- /css/css-ruby/parsing/ruby-overhang-valid.html [wpt.fyi]
- e.style['ruby-overhang'] = "auto" should set the property value:
FAIL - e.style['ruby-overhang'] = "none" should set the property value:
FAIL - e.style['ruby-overhang'] = "spaces" should set the property value:
FAIL
- e.style['ruby-overhang'] = "auto" should set the property value:
- /css/css-ruby/parsing/ruby-position-valid.html [wpt.fyi]
- e.style['ruby-position'] = "inter-character" should set the property value:
FAIL
- e.style['ruby-position'] = "inter-character" should set the property value:
- /css/css-ruby/line-spacing.html [wpt.fyi]
- Don't Consume half-leading of the previous line with text-emphasis:
FAIL - Don't Consume half-leading of the next line with text-emphasis:
FAIL
- Don't Consume half-leading of the previous line with text-emphasis:
Comment 4•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/09327f48c09c
https://hg.mozilla.org/mozilla-central/rev/214f7dddd510
Description
•