Closed Bug 2069316 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62422 - ruby: Propagate block-end annotation space in multicol containers

Categories

(Core :: Layout: Ruby, task, P4)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62422 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62422
Details from upstream follow.

Kent Tamura <tkent@chromium.org> wrote:

ruby: Propagate block-end annotation space in multicol containers

Previously, block-end annotation space propagation was disabled for
children of balanced multicol containers to avoid issues in an existing
WPT test about column balancing. This CL enables it.

This CL fixes BlockLayoutAlgorithm::FinishLayout() so that to compute
the available annotation space correctly for fragmented containers.

Bug: 445727139, 538260158
Change-Id: I27848eba96cb7f8ae8eb775d725455e0bc8d8748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8294040
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Auto-Submit: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1691451}

Component: web-platform-tests → Layout: Ruby
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 177 tests and 6 subtests

Status Summary

Firefox

OK : 1[GitHub] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2[GitHub] 13[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 88[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 185[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 1[GitHub] 15[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 61[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
PASS: 2
FAIL: 1

Safari

OK : 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.