20694 - [dogfood][crash]Color selection in editor causes crash

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[[e-mail]]

This is in 1999120208, Mac OS 8.6

When I'm composing a new message and try to select a colour to assign to a
selected text element it CRASHES while trying to deactivate that selection
dialogue.

Comment 1

[Jean-Francois Ducarroz]

reassign to editor team.

Comment 2

[rubydoo123]

reassigning this to Charley for debugging

Comment 3

[Charles Manske]

It doesn't crash on Windows, but it also doesn't work (i.e., set the color)
Do any of the other color pickers crash?
For example, from any window, try Edit | Preferences | Appearance | Colors and
try to use the color picker for "text".
If that also crashes, it is a general problem and not editor-specific

Comment 4

[[e-mail]]

It does not crash in the Preferences>Appearance>Colours dialog. It seems to be
editor-specific.

Comment 5

[Charles Manske]

I'm not seeing any problems in Windows.
Simon and/or Kathy: Could you please investigate this for Mac? Stack trace if
it crashes?
Sujay: What happens in linux?

Comment 6

[sujay]

yes definitely a problem on Mac and Linux Charley....crashes exactly as
described .

tested in 12/4 build on Mac and 12/6 build of linux.

Comment 7

[leger]

Colour nice, but not needed for dogfood.  Putting on PDT- radar.

Comment 8

[rubydoo123]

moving to M13

Comment 9

[Kathleen :Brade]

shorten summary and add [crash]. Add dependency to 20412 at hyatt's suggestion.



Crash is in nsMenuDismissalListener::Rollup() at the point of executing

mMenuParent->HideChain();



Charley--once Hyatt fixes 20412 you'll have an API or a way to cause the popups

to cleanup properly.

Comment 10

[Jean-Francois Ducarroz]

*** Bug 21735 has been marked as a duplicate of this bug. ***

Comment 11

[lchiang]

should release note for M12.

Comment 12

[Karen Huang]

Problem also happened to Linux 12-17-10-M12 commercial build.
Change platforms/OS to all.

Comment 13

[Simon Fraser [no longer active]]

What I see is this. I select some text, and click the color swatch on the
toolbar. The color picker comes up in some random location. I click on a color;
nothing seems to happen. I click again, and the *parent* window (i.e. the
composer window) goes away. Now, if I try to change window layering, I crash.

Comment 14

[Charles Manske]

In the <popup> window that contains the colorpicker, the onclick handler for
the colorer picker is: "EditorSelectTextColor(); window.close()"
Calling window.close() is supposed to close the color picker (according to
hyatt), but it does noting on Windows, and it closes the parent window on Mac
and LINUX, which explains the observed behavior. This closing is obviously not
"clean" and results in crashes when other windows are clicked on.
DanM will help me look into the problem - CCing him.

Comment 15

[Stuart Parmenter]

window.close() is for domwindows.  <menupopup>'s are not domwindow's and
therefore calling window.close() will close the domwindow.  to clos ethe
menupopup, I am pretty sure you have to do removeAttribute(menupopup,"open") or
something similar to a different attribute... i don't remember what the
attribute is though.  hyatt should know.

Comment 16

[Charles Manske]

Checked in 12/22

Comment 17

[sujay]

verified in 12/3 build.