2069503 - [Nova] Visual refinements for private window theme

Status: VERIFIED FIXED

(Firefox :: Private Browsing, enhancement)

Description

[Eric Pang [:epang] UX]

Because of the update to remove outer and inner borders the default light and themes were no longer applying as intended. The issues are mainly more visible in vertical tabs with the bookmark toolbar on.

I've created UX spec updates that address the visual issues:
https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?m=auto&node-id=37809-246062&t=T4qVC7aaJSkQQfA1-1

I'm unclear of https://bugzilla.mozilla.org/show_bug.cgi?id=2069497 will fix this issue for private browsing or not.

Please view specs for details, but at a high level here's what's changed.

Horizontal tabs

• The gradient from the tab bar now appears as the entire background of the window
• Toolbar and bookmarks toolbar (if on) have a 20% black transparency
• Borders around the content window and sidebar panels is reduced to 50% opacity

Vertical tabs

• The gradient from the tab bar now appears as the entire background of the window including the sidebar + bookmark toolbar (if on)
• Borders around the content window and sidebar panels is reduced to 50% opacity

Comment 1

[Emilio Cobos Álvarez [:emilio]]

The gradient from the tab bar now appears as the entire background of the window

This seems done (by bug 2069090).

Toolbar and bookmarks toolbar (if on) have a 20% black transparency.

You mean white? The private window theme is dark so applying transparent black makes it a lot darker.

Borders around the content window and sidebar panels is reduced to 50% opacity

Easy enough.

The gradient from the tab bar now appears as the entire background of the window including the sidebar + bookmark toolbar (if on)

Same, already done.

Borders around the content window and sidebar panels is reduced to 50% opacity

Same change as for horizontal tabs.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2069503 - Minor private window theme tweaks. r=#theme!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ad017ecbcb13
https://hg.mozilla.org/integration/autoland/rev/3a7d6c730a3c
Minor private window theme tweaks. r=desktop-theme-reviewers,sfoster

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3a7d6c730a3c

Comment 5

[Negritas Sergiu, Desktop QA]

Hello! I can confirm that the issue is fixed with firefox 157.0b3 on MacOS 26, on Ubuntu 24 there is still a discrepancy between the bookmarks and the tabstrip as in the attached screen shot in the bug from the description, I have tried with different themes for ubuntu but the discrepancy is still present .

Is this intended for Ubuntu 24?

Comment 6

[Eric Pang [:epang] UX]

The update should be consistent in Ubuntu 24 with mac and windows. Note: In horizontal tabs the background should be there, but not on vertical tabs. Emilio, is there a reason why there may still be a discrepancy on Ubuntu?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

I couldn't parse comment 5, what screenshot, you mean bug 2069497 comment 10? If so, I don't see it on nightly and it seems it might be an older beta build or so? That said this patch shouldn't change that in any way.

Comment 8

[Negritas Sergiu, Desktop QA]

Hello! I can confirm that the issue is fixed with 2069497 I have verified again with the latest beta 157.0b4 and the discrepancy is not present anymore.

I will update the flags and status of this issue based on the fix from 2069497

Have a nice day!