2069673 - Suppress clang 23 unused warnings in vendored Chromium code

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, task)

Description

[Ryan VanderMeulen [:RyanVM]]

clang 23.1.0 puts -Wunused-template under -Wall and nests -Wunused-but-set-global under -Wunused-but-set-variable. Two vendored Chromium files trip them:

• security/sandbox/chromium/base/strings/utf_string_conversions.cc and its copy at third_party/zucchini/chromium/base/strings/utf_string_conversions.cc: unused conversion templates (-Wunused-template).
• security/sandbox/chromium/sandbox/win/src/sandbox.cc: a write-only static (-Wunused-but-set-global).

Both directories are vendored Chromium code that we don't modify, and security/sandbox/moz.build already carries per-file warning suppressions for the same reason (bug 2066694). Extend that precedent with -Wno-unused-template / -Wno-unused-but-set-global on the affected files in security/sandbox/moz.build and third_party/zucchini/moz.build, one patch per directory.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2069673 - Silence clang 23 unused warnings in the vendored Chromium sandbox code. r?#sandbox-reviewers

The 32-bit UnicodeAppendUnsafe overload is unused where wchar_t is 16 bits, and s_is_broker is only ever
written. Both are unchanged in upstream Chromium.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2069673 - Silence -Wunused-template in zucchini's Chromium base code. r?#application-update-reviewers

The 32-bit UnicodeAppendUnsafe overload is unused where wchar_t is 16 bits and is unchanged upstream.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e42b0aaf62ca
https://hg.mozilla.org/integration/autoland/rev/d0da32b974a4
Silence clang 23 unused warnings in the vendored Chromium sandbox code. r=sandbox-reviewers,bobowen
https://github.com/mozilla-firefox/firefox/commit/14d1609f773d
https://hg.mozilla.org/integration/autoland/rev/5b8434dc051a
Silence -Wunused-template in zucchini's Chromium base code. r=bobowen

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d0da32b974a4
https://hg.mozilla.org/mozilla-central/rev/5b8434dc051a