Closed Bug 2069696 Opened 1 month ago Closed 1 month ago

Update quinn-udp to 0.6.2

Categories

(Core :: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox-esr153 --- fixed
firefox158 --- fixed

People

(Reporter: mail, Assigned: mail)

References

()

Details

(Whiteboard: [necko-triaged])

Attachments

(2 external files)

macOS: 0.6.0 declares the private sendmsg_x and recvmsg_x as hard extern "C" symbols whenever the fast-apple-datapath feature is on. 0.6.1 resolves them lazily and falls back to sendmsg/recvmsg: https://github.com/quinn-rs/quinn/pull/2571

Linux: 0.6.0 binds two throw-away UDP sockets per UdpSocketState::new to probe UDP_SEGMENT and UDP_GRO. A failed bind silently reports max_gso_segments = 1 and we lose GSO. 0.6.1 probes the socket it is handed instead: https://github.com/quinn-rs/quinn/pull/2565

0.6.2 adds the Windows fixes: USO disabled after GSO probing (https://github.com/quinn-rs/quinn/pull/2824), no panic in UdpSocketState::new on an unbound socket (https://github.com/quinn-rs/quinn/pull/2821), WSARecvMsg resolved per socket (https://github.com/quinn-rs/quinn/pull/2825). Also a macOS EWOULDBLOCK fix (https://github.com/quinn-rs/quinn/pull/2727), EMSGSIZE from ICMP fragmentation needed (https://github.com/quinn-rs/quinn/pull/2736) and musl cmsg fixes (https://github.com/quinn-rs/quinn/pull/2750).

Release notes: https://github.com/quinn-rs/quinn/releases/tag/quinn-udp-0.6.2

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
Blocks: 2068899
QA Whiteboard: [qa-triage-done-c159/b158]

firefox-esr153 Uplift Approval Request

  • User impact if declined/Reason for urgency: Fixes a third-party bug that causes Windows startup crashes in the presence of end-system security software. Details in https://bugzilla.mozilla.org/show_bug.cgi?id=2068899#c3
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: N/A
  • Risk associated with taking this patch: low
  • Explanation of risk level: Shipped in 157 band 158 with no more reported crashes.
  • String changes made/needed?: N/A
  • Is Android affected?: no
Attachment #9665127 - Flags: approval-mozilla-esr153?
Attachment #9665127 - Flags: approval-mozilla-esr153? → approval-mozilla-esr153+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: