Closed Bug 2069839 Opened 2 months ago Closed 1 month ago

[customizable-menu] Show the refresh menu item in browser screen's menu

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: petru, Assigned: giorga)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(1 external file)

Needed:

  • a BrowserMenuBuilder that has a hardcoded structure of the default home menu
  • this is instantiated by the MenuStores middleware and queried for the menu configuration to use
  • the configuration is updated by the MenuStores middleware to be displayed
  • the MenuStores middleware will handle the menu item interactions
Assignee: nobody → giorga
Attachment #9643883 - Attachment description: Bug 2069839 - [customizable-menu] Show the refresh menu item in browser screen's menu → Bug 2069839 - [customizable-menu] Show the refresh menu item in browser screen's menu r=#android-reviewers
Pushed by giorga@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0ab7da7868c7 https://hg.mozilla.org/integration/autoland/rev/96515c76b20d [customizable-menu] Show the refresh menu item in browser screen's menu r=android-reviewers,petru
Pushed by nfay@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/22f91a803813 https://hg.mozilla.org/integration/autoland/rev/5b162d0381b6 Revert "Bug 2069839 - [customizable-menu] Show the refresh menu item in browser screen's menu r=android-reviewers,petru" for causing fenix failure

Backed out for causing fenix failure

Backout link

Push with failures

Failure log

Flags: needinfo?(giorga)
Pushed by giorga@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/76f530c4ed5c https://hg.mozilla.org/integration/autoland/rev/1d467812d980 [customizable-menu] Show the refresh menu item in browser screen's menu r=android-reviewers,petru
Flags: needinfo?(giorga)
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: