Closed Bug 2069851 Opened 2 months ago Closed 1 month ago

[customizable-menu] Show the summarize page menu item in browser screen's menu

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: petru, Assigned: petru)

References

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(2 external files)

Needed:

  • a BrowserMenuBuilder that has a hardcoded structure of the default home menu
  • this is instantiated by the MenuStores middleware and queried for the menu configuration to use
  • the configuration is updated by the MenuStores middleware to be displayed
  • the MenuStores middleware will handle the menu item interactions
Assignee: nobody → petru
Status: NEW → ASSIGNED

Some constraints needed to be supported:

  • what subMenu items are shown in "More" is only known after "More" is built
  • the "Summarize page" menu item may be moved out / removed by the user (to be supported later)
  • whether to highlight "Summarize page" and "More" uses different conditions
Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b96831df415c https://hg.mozilla.org/integration/autoland/rev/b8016304bf8d part 1 - Show the "Summarize page" menu item in browser screen's menu r=android-reviewers,giorga https://github.com/mozilla-firefox/firefox/commit/157068d02b3d https://hg.mozilla.org/integration/autoland/rev/c15b29115e18 part 2 - Highlight "More" to drag attention to the summarize page menu item r=android-reviewers,giorga
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: