2069952 - destinationFolder should be mandatory for browser.setDownloadBehavior({type: "allowed"})

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Julian Descottes [:jdescottes]]

When implementing the command initially, we missed an argument check for setDownloadBehavior. When type="allowed", the downloadFolder parameter is mandatory.

See https://github.com/w3c/webdriver-bidi/pull/1008

We should also update the invalid tests to enforce that.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 2069952 - [bidi] Make destinationFolder mandatory for browser.setDownloadBehavior with type=allowed

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 2069952 - [wdspec] Add test to check that destinationFolder is mandatory for browser.setDownloadBehavior with type=allowed

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/84e51c90ab28
https://hg.mozilla.org/integration/autoland/rev/f7f781ee8ce9
[bidi] Make destinationFolder mandatory for browser.setDownloadBehavior with type=allowed r=whimboo
https://github.com/mozilla-firefox/firefox/commit/0e102eaccce3
https://hg.mozilla.org/integration/autoland/rev/0db517a31f44
[wdspec] Add test to check that destinationFolder is mandatory for browser.setDownloadBehavior with type=allowed r=whimboo

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f7f781ee8ce9
https://hg.mozilla.org/mozilla-central/rev/0db517a31f44

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62556 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot