2070023 - Many “Error when running gcov” errors on ccov builds

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Nicolas Guichard]

The build-android-x86_64-ccov/opt, build-linux64-ccov/opt and build-win64-ccov/opt logs are full of “Error when running gcov” errors when running parse_build_tests_ccov.py.

As far as I can tell, like in bug 2008110 grcov shouldn't be calling out to gcc's gcov but should be parsing gcno files itself. Adding the --lvm flag could be enough, I have a Try run in progress to test this.

Comment 1

[Nicolas Guichard]

By setting --llvm, I now get many “"./../../../some/path/to.cpp" cannot be normalized because of "..", so skip it.” warnings. This only happens with unified builds and I think it is related to bug 2033336.

With GCC, this would be fixed by passing -fprofile-abs-path: “Automatically convert relative source file names to absolute path names in the .gcno files. This allows gcov to find the correct sources in projects where compilations occur with different working directories.”. But Clang doesn't have that flag. We could eventually add that flag upstream, but grcov could already treat relative paths in gcno files as relative to the gcno file itself.

Comment 2

[Nicolas Guichard]

Attachment: Bug 2070023 - Call grcov with --llvm in parse_build_tests_ccov.py. r?marco!

For bug 2008110 I added the --llvm flag in codecoverage.py but missed
it here.

This aims to fix lots of errors like:

[ERROR] Error when running gcov: gcov execution failed on uniffi-40f9f7591a3b9d67_1.gcno
gcov stdout:
gcov stderr: uniffi-40f9f7591a3b9d67_1.gcno:version 'B11*', prefer 'B22*'

on Android CCov builds

and

[ERROR] Error when running gcov: Failed to execute gcov process

on Linux/Windows CCov builds.

grcov should never call gcov because our CCov builds are always built
with Clang.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9234a501f99f
https://hg.mozilla.org/integration/autoland/rev/5c7b3d954606
Call grcov with --llvm in parse_build_tests_ccov.py. r=marco

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5c7b3d954606