2070101 - Add Calendar Read Dialog Edit control for editable events

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, task, P3)

Description

[Alex Schmitz]

Summary:
Add an Edit button to the Calendar Read Dialog. Show it only when the user can
edit the event being shown. Bug 2020692 makes the button open an editor.

Finish setting up the button before showing and positioning the dialog. The
button must not appear late and change the size of an already positioned dialog.

Links:

• Redux: Selectors and Rendering
• Bug 2061191: Shared event loader
• Bug 2020654: Calendar event read work
• Zeplin design
• Bug 2020692: Open the editor from this button

Acceptance criteria:

• Put an Edit button in the dialog's action area. Give it a translated name
  and support keyboard and screen-reader access.
• Show Edit only after the current event has loaded and editing is allowed.
• Hide Edit while loading, after a load error, when editing is not allowed,
  or when the dialog clears or changes its event.
• If the dialog switches from event A to event B, a late result for A must not
  show an Edit button for B.
• Set the button's visibility before the dialog is shown and positioned.
  The button must not change the dialog size after positioning.

Required implementation details:

• Use canEdit from the current source session supplied by Bug 2061191. A source
  session identifies one request to load an event; its result must match the
  event now shown in the dialog.
• Render from the initial Redux update when the dialog connects, then from
  later updates through storeObserver. Do not add a getter that reads the store.
• Selectors read Redux state only. Keep live events, calendar objects, and DOM
  objects outside Redux; store only serializable IDs, values, and data objects.
• Complete the visibility update before PositionedDialog.show() runs. Keep the
  existing rule that loading and initial rendering finish before positioning.

Minimum test coverage:

• Check the button's translated accessible name and keyboard access.
• Check the initial Redux update and later changes to editing permission.
• Check editable events, non-editable events, loading, load errors, and clearing
  or replacing the event.
• Load A, switch to B, then finish loading A. Check that A cannot show Edit for B.
• Check the button state before positioning and that it causes no later growth.
• Run axe checks on the displayed states where supported.

Out of scope:

• Opening either editor; Bug 2020692 owns that work.
• Adding the new-dialog preference or deciding which editor to open.
• Changing positioning or sizing beyond preserving the existing load-before-show rule.

Comment 1

[Vineet Deo]

Attachment: Bug 2070101 - Calendar Read Dialog: Add edit button and show/hide button if event is editable. r=#thunderbird-front-end-reviewers

How to Test

• Turn on new calendar read dialog
• Add a calendar that has events that aren't yours
• Create an event
• Check if edit button is visible on new event
• On your local calendar, right click and open properties and check "Read Only" to test edit button visibilty
• Check edit button is not visible on events you don't own

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6690b93ffd4c
Calendar Read Dialog: Add edit button and show/hide button if event is editable. r=tobyp,klamping