Closed Bug 2070220 Opened 2 months ago Closed 2 months ago

Replace mozjemalloc critical section on windows with an atomic futex mutex

Categories

(Core :: Memory Allocator, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: denispal, Assigned: denispal)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert, Whiteboard: [foofrix:dde3baac-9b93-4107-a95d-6fa25dd9bfe2])

Attachments

(1 external file)

Switching the allocator mutex Windows from a critical section to an atomic futex mutex is about a 1% improvement in SP3.

The severity field is not set for this bug.
:jlink, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jlink)
Type: defect → enhancement
Flags: needinfo?(jlink)
Component: Performance: Memory → Memory Allocator
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch

Perfherder has detected a browsertime performance change from push b3cf98f47353c5d1496eccd83d50ed8b6959344d.

No action is required from the author; this comment is provided for informational purposes only.

Improvements Test Platform Options Absolute values [old vs new] Performance Profiles
3% stylebench Dynamic media queries/Resizing to 450px - 3/Sync (doc) windows11-64-24h2-shippable fission webrender 7.98 ms -> 7.75 ms Before/After
3% stylebench Dynamic media queries/Resizing to 450px - 4/Sync (doc) windows11-64-24h2-shippable fission webrender 7.96 ms -> 7.74 ms Before/After
3% stylebench Dynamic media queries/Resizing to 650px - 2/Sync (doc) windows11-64-24h2-shippable fission webrender 8.06 ms -> 7.84 ms Before/After
3% stylebench Dynamic media queries/Resizing to 450px - 3 (doc) windows11-64-24h2-shippable fission webrender 8.98 ms -> 8.75 ms Before/After
2% stylebench Dynamic media queries/Resizing to 450px - 4 (doc) windows11-64-24h2-shippable fission webrender 8.96 ms -> 8.74 ms Before/After
... ... ... ... ... ...
2% stylebench Dynamic media queries/Resizing to 500px - 2 (doc) windows11-64-24h2-shippable fission webrender 8.87 ms -> 8.69 ms Before/After

Need Help or Information?

If you have any questions, please reach out to bacasandrei@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert

Perfherder has detected a mozperftest performance change from push b3cf98f47353c5d1496eccd83d50ed8b6959344d.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
7% browser_removeManySpellingErrors.js A11Y_TotalTime windows11-64-24h2-shippable 116.20 ms -> 108.28 ms
5% ML Semantic History Search LONG-SEMANTIC-search-latency-NATIVE windows11-64-24h2-hw-ref-shippable 1.74 ms -> 1.65 ms

Need Help or Information?

If you have any questions, please reach out to aesanu@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Perfherder has detected a talos performance change from push b3cf98f47353c5d1496eccd83d50ed8b6959344d.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
6% perf_reftest_singletons tiny-traversal-singleton.html (doc) windows11-64-24h2-shippable e10s fission stylo webrender 315.96 ms -> 297.24 ms

Need Help or Information?

If you have any questions, please reach out to aesanu@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

QA Whiteboard: [qa-triage-done-c159/b158]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: