2070270 - Standardize search UI across Weather, Stocks and Clocks widgets

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Maxx Crawford [:maxx]]

Please use the Stocks search implementation as reference for these updates. Enter.

Weather (content-src/components/Weather/LocationSearch.jsx, _Weather.scss)

• Add the back button from Stocks search.
• Shrink the search icon: it is larger than the Clocks and Stocks icons.
• Add the clear ("x") button.
• Align the placeholder text with Clocks/Stocks.
• Fix the focus state: the outline weight/border does not match Clocks or Stocks.
• Suggestion dropdown appears while typing. If suggestions cannot render inside the widget the way Stocks does, at minimum match the Clocks dropdown style.

Clocks (content-src/components/Widgets/Clocks/AddClockForm.jsx, _Clocks.scss)

• Make the suggestions dropdown style consistent with Weather.
• Round the nickname field's border radius to match the location field.

See Jira for full context and screenshots: https://mozilla-hub.atlassian.net/browse/HNT-3067

Comment 1

[Reem Hamoui (PTO - back Nov 23)]

Attachment: Bug 2070270 - Standardize widgets search UI. r=#home-newtab-wattle-reviewers-rotation

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/57a7ad31b218
https://hg.mozilla.org/integration/autoland/rev/c0dad7fa8c2d
Standardize widgets search UI. r=fluent-reviewers,nina-py,bolsson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61d08b3df422
https://hg.mozilla.org/integration/autoland/rev/023a996c9dad
Revert "Bug 2070270 - Standardize widgets search UI. r=fluent-reviewers,nina-py,bolsson" for causing lint failures

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing lint failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/023a996c9dad02c7268b18aacd8af64736b40123

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9129f4e7921b
https://hg.mozilla.org/integration/autoland/rev/f0c4beea900d
Standardize widgets search UI. r=fluent-reviewers,nina-py,bolsson

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f0c4beea900d