Closed Bug 2070272 Opened 2 months ago Closed 1 month ago

Standardize context menu button UI across all widgets

Categories

(Firefox :: New Tab Page, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
159 Branch
Tracking Status
firefox159 --- fixed

People

(Reporter: maxx, Assigned: dgrant)

References

(Blocks 1 open bug)

Details

(Whiteboard: [hnt][hnt-wattle])

Attachments

(1 file, 2 external files)

  • Make all context menu icon button -small
  • Position the context menu at the same distance (12px top - 12px right padding)
  • Consistent tooltips (add tooltips to those missing - [widget name] open menu
Attached image image.png —
Whiteboard: [hnt][hnt-wattle]

Each widget's menu button gets an "Open [widget name] menu" string that sets both the tooltip and the screen reader label. The old strings stay until the follow-up patch switches the widgets over and removes them.

Assignee: nobody → dgrant
Status: NEW → ASSIGNED

Widget menu buttons came in two sizes and sat at different distances from the card corner. Several had no tooltip. This adds a shared WidgetMenuButton for the small "…" button and uses it in every widget except Sports and Weather forecast, with Privacy, Focus timer, Stocks and Clocks moved to the shared corner spacing. Each button now uses its "Open [widget name] menu" string from D329642, so the old strings are removed.

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch

Bug 2074257 renamed everything to Finance, this landed a string still mentioning "Stocks"?

Flags: needinfo?(dgrant)
Attachment #9650242 - Attachment description: Bug 2070272 - Standardize the widget menu button. r?#home-newtab-reviewers → Bug 2070272 - Standardize the widget menu button. r?#fluent-reviewers,#home-newtab-reviewers

Yep, this was done before the name change. But it's now Fixed in D329787. It adds newtab-stocks-widget-open-menu-button2 with "Open finance menu" and removes the old Stocks string.

Flags: needinfo?(dgrant)
See Also: → 2078497
See Also: → 2079484
QA Whiteboard: [qa-triage-done-c160/b159]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: