2070281 - "Discover extensions" button shown multiple times

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Rob Wu [:robwu]]

Attachment: multiple-discover-extensions-button-from-reddit.webp

I saw this report: https://www.reddit.com/r/softwaregore/comments/1wa77qc/calm_down_firefox_ill_discover_some_new_extentions/

That's puzzling because there is logic that is supposed to clean up the button when the panel is removed: onPanelViewHiding in browser-addons.js

The button is created and added here in onPanelViewShowing in browser-addons.js.

... upon looking at that, I see how it could happen: the button is not immediately inserted, but asynchronously from onPanelViewShowing, after a call to getDisabledExtensionsInfo() resolves. The getDisabledExtensionsInfo method could potentially take a non-trivial amount of time when there are no extensions. If a user spam clicks the Extensions button a couple of times before the full extension database is initialized, they could end up in the situation as reported on Reddit.

To fix this we should return early from .getDisabledExtensionsInfo().then( if the panel has closed in the meantime.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 2070281 - Avoid duplicate Discover extensions buttons

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7baba728c587
https://hg.mozilla.org/integration/autoland/rev/b100f58c3fdf
Avoid duplicate Discover extensions buttons r=rpl

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/b100f58c3fdf