Closed
Bug 2070421
Opened 24 days ago
Closed 23 days ago
coreconf/config.gypi does not set _NSPR_BUILD_ on Windows
Categories
(NSS :: Build, defect, P3)
Tracking
(nss 3.130)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| nss | --- | 3.130 |
People
(Reporter: leggert, Assigned: leggert)
Details
Attachments
(1 file)
NSPR's Windows headers only mark PR_* as a plain external, instead of dllimport, when _NSPR_BUILD_ is defined. NSS's own gyp targets don't define it, so code in lib/ssl and lib/softoken (PR_OpenAnonFileMap, PR_GetDirectorySeparator, etc.) still needs NSPR's DLL import library even in a --static build, so the result isn't actually self-contained. (Firefox does this, too.)
|
Assignee | |
Comment 1•24 days ago
|
||
|
||
Updated•23 days ago
|
Assignee: nobody → leggert
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by jschanck@mozilla.com:
https://hg.mozilla.org/projects/nss/rev/c4b3a73b279c
Set NSPR_BUILD for Windows builds r=nss-reviewers,jschanck
Status: ASSIGNED → RESOLVED
Closed: 23 days ago
Resolution: --- → FIXED
|
||
Updated•10 days ago
|
status-nss:
--- → 3.130
You need to log in
before you can comment on or make changes to this bug.
Description
•