2070576 - [customizable-menu] Show the extensions menu item in custom tabs menu

Status: RESOLVED FIXED

(Firefox for Android :: Menu, task)

Description

[Petru-Mugurel Lingurar [:petru]]

Needed:

• a CustomTabsMenuBuilder that has a hardcoded structure of the default custom tabs menu
• this is instantiated by the MenuStores middleware and queried for the menu configuration to use
• the configuration is updated by the MenuStores middleware to be displayed
• the MenuStores middleware will handle the menu item interactions

Comment 1

[Iorga Gabriel]

Attachment: Bug 2070576 - [customizable-menu] Show the extensions menu item in custom tabs menu

Comment 2

[Rob Wu [:robwu]]

This is about providing parity to the menu behavior ad inplemented in bug 1986697, right? I'm linking the bugs for context because one downside to a completely new implementation without context is that it becomes difficult to trace design decisions when using git blame. Bug 1986697 links to multiple bugs that together have some relevant context.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/92639d17dbeb
https://hg.mozilla.org/integration/autoland/rev/e6a3d69d73ed
[customizable-menu] Show the extensions menu item in custom tabs menu r=android-reviewers,petru

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e6a3d69d73ed