2070639 - Strip whitespace when translating role

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

In bug 1894410 I stripped the whitespace from the tokens in the cached hash of tokens to localized strings. I didn't do the same when we actually do the translation. The test case I wrote mistakenly used a token without any whitespaces so it was guaranteed to pass.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 2070639 - Strip whitespaces from role names when retreiving localized versions. r?Jamie

Comment 2

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:eeejay, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/41e8f0386975
https://hg.mozilla.org/integration/autoland/rev/54f6fb291aa2
Strip whitespaces from role names when retreiving localized versions. r=Jamie,geckoview-reviewers,m_kato

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/54f6fb291aa2