2070849 - Convert tabs.js to a module and type the tab strip from its class

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Dão Gottwald [:dao]]

browser/components/tabbrowser/content/tabs.js is loaded as a subscript, so TypeScript cannot see MozTabbrowserTabs. Nothing stands in for the tab strip either, so every tabContainer access in Tabbrowser.sys.mjs goes unchecked.

Make it a .mjs that exports its class and defines the element, imported with { global: "current" } where the subscript was loaded, the way Bug 2066073 did for tabgroup.js and tabsplitview.js. Then declare MozElements.TabsBase in tools/@types/lib.gecko.augmentations.d.ts - an undeclared base makes every inherited member vanish - and point types/elements.ts at the real class.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2070849 - Rename the tab strip element script to .mjs. r?#tabbrowser-reviewers-rotation!

The .mjs extension turns on no-shadow with builtinGlobals, so three locals shadowing window.name, window.parent and window.closed are renamed here.

The subscript loader does not read the extension, so the file still loads as before. Dropping "use strict", which eslint rejects in a .mjs, leaves it sloppy until the next commit makes it a real module; nothing outside the class body depends on strictness.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 2070849 - Declare the tab strip element script's globals in the file. r?#tabbrowser-reviewers-rotation!

The browser-window eslint environment harvests its globals from the scripts browser-main.js loads with loadSubScript, and hands the set back to those same scripts. Once the next commit imports this one as a module instead, it is neither harvested nor handed anything, so the globals it uses have to be named here.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 2070849 - Turn the tab strip element into a module. r?#tabbrowser-reviewers-rotation!

Dropping the indentation-preserving block re-indents the whole file, so git diff -w is the actual change: the export, and the import that replaces the subscript load.

The three cannot be separated. export is top-level only, so it needs the block gone; and once the block is gone the file's own top-level names collide with the browser-window globals harvested from browser-main.js's loadSubScript line, which only the import removes.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 2070849 - Declare MozElements.TabsBase for TypeScript. r?Standard8

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 2070849 - Type the tab strip from its class. r?#tabbrowser-reviewers-rotation!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e3ff7020e148
https://hg.mozilla.org/integration/autoland/rev/0dff829f609e
Rename the tab strip element script to .mjs. r=tabbrowser-reviewers,jsudiaman,frontend-codestyle-reviewers

Comment 7

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/0dff829f609e

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ada0b5fee70b
https://hg.mozilla.org/integration/autoland/rev/734f34d74cdb
Turn the tab strip element into a module. r=tabbrowser-reviewers,jsudiaman
https://github.com/mozilla-firefox/firefox/commit/03df31713d6a
https://hg.mozilla.org/integration/autoland/rev/3c676a88105c
Declare MozElements.TabsBase for TypeScript. r=Standard8
https://github.com/mozilla-firefox/firefox/commit/e7de89a8b2e7
https://hg.mozilla.org/integration/autoland/rev/72c8ebe25e96
Type the tab strip from its class. r=tabbrowser-reviewers,jsudiaman

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/734f34d74cdb
https://hg.mozilla.org/mozilla-central/rev/3c676a88105c
https://hg.mozilla.org/mozilla-central/rev/72c8ebe25e96

Comment 10

[Dão Gottwald [:dao]]

Attachment: Bug 2070849 - Ignore the tab strip module conversion in blame and annotate. r?#firefox-desktop-core-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/df8487d6e12e
https://hg.mozilla.org/integration/autoland/rev/fb806040e208
Ignore the tab strip module conversion in blame and annotate. r=firefox-desktop-core-reviewers ,mossop

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fb806040e208

Comment 13

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)