207085 - Updating a stored query shouldn't return the same message as creating one

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[timeless]

Comment 1

[timeless]

Attachment: add response

Comment 2

[Christian Reis]

Comment on attachment 124184 [details] [diff] [review]
add response

>         foreach my $query (@{$vars->{'user'}{'queries'}}) {
>-            if ($query->{'name'} eq $name && $query->{'linkinfooter'} == 1) {
>+            if ($query->{'name'} eq $name) {
>+                $vars->{'message'} = "buglist_updated_named_query";
>+                if ($query->{'linkinfooter'} == 1) {
>                 $new_in_footer = 0;
>             }
>         }        

You missed a close-bracket there and the indent is wrong. I'd also suggest
adding a break to that if clause as a micro-optim-correctness thing.

r=kiko with those changes, this is nice.

Comment 3

[timeless]

you mean last :) oh well. fixed.

Comment 4

[Dave Miller [:justdave]]

Next time please get approval for your bug *before* you check it in.  Thanks.