Updating a stored query shouldn't return the same message as creating one

RESOLVED FIXED in Bugzilla 2.18

Status

()

RESOLVED FIXED
16 years ago
6 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

unspecified
Bugzilla 2.18
x86
Windows 2000
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
 
(Assignee)

Comment 1

16 years ago
Created attachment 124184 [details] [diff] [review]
add response
(Assignee)

Updated

16 years ago
Attachment #124184 - Flags: review?(kiko)

Comment 2

16 years ago
Comment on attachment 124184 [details] [diff] [review]
add response

>         foreach my $query (@{$vars->{'user'}{'queries'}}) {
>-            if ($query->{'name'} eq $name && $query->{'linkinfooter'} == 1) {
>+            if ($query->{'name'} eq $name) {
>+                $vars->{'message'} = "buglist_updated_named_query";
>+                if ($query->{'linkinfooter'} == 1) {
>                 $new_in_footer = 0;
>             }
>         }        

You missed a close-bracket there and the indent is wrong. I'd also suggest
adding a break to that if clause as a micro-optim-correctness thing.

r=kiko with those changes, this is nice.
Attachment #124184 - Flags: review?(kiko) → review-
(Assignee)

Comment 3

16 years ago
you mean last :) oh well. fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Next time please get approval for your bug *before* you check it in.  Thanks.
Flags: approval+
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.