2070908 - SetFocus(Raise::Yes) does not activate the application on macOS, causes test failures

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Florian Quèze [:florian]]

On macOS nsCocoaWindow::SetFocus(Raise::Yes) only calls [mWindow makeKeyAndOrderFront:nil], and AppKit will not make a window key while its application is inactive. Windows uses SetForegroundWindow and GTK uses gtk_window_present, so mac is the one platform where Raise::Yes does not honour its contract.

A browser-chrome test that launches the browser toolbox takes application activation away with -foreground and never gets it back. Every test after it then hangs in SimpleTest.waitForFocus(), waiting for a focus event that cannot arrive, which is the failure Bug 1937315 recorded when it was filed. Adding [NSApp activateIgnoringOtherApps:YES] on that path fixes it.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 2070908 - Activate the application when asked to raise a window on macOS, r=#mac-reviewers.

Raise::Yes did nothing while Firefox was not the active application, where GTK
activates through gtk_window_present_with_time. Only nsFocusManager::RaiseWindow
reaches this on macOS, after BrowsingContext::CanFocusCheck grants the raise,
and mozilla.widget.raise-on-setfocus is a kill switch. The mac arms un-skipped
here are the browser-chrome harness waiting forever for a focus event once the
Browser Toolbox has taken activation: Bug 1937229, Bug 1937315, Bug 1767721,
Bug 1781499.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/66f7f4704be7
https://hg.mozilla.org/integration/autoland/rev/8320591aecd1
Activate the application when asked to raise a window on macOS, r=mac-reviewers,devtools-reviewers,bradwerth,jdescottes.

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/8320591aecd1