2070932 - Intermittent browser_dbg-ember-original-variable-mapping-notifications.js | Test timed out

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Florian Quèze [:florian]]

browser_dbg-ember-original-variable-mapping-notifications.js times out with no failure message. It failed 8 times in three weeks on windows11-64-25h2 opt, and the in-job rerun passed every time.

The ember quickstart page has four original sources named router.js, so waitForSources(dbg, "router.js") is satisfied by any of them. When one of the vendor ones wins, the line the test breakpoints falls inside a doc comment with no breakable position. addBreakpoint then returns without dispatching SET_BREAKPOINT, and the test waits on that dispatch until the timeout.

The fix is to pass the app router's full URL to invokeWithBreakpoint instead of the bare "router.js". findSource already accepts a full URL, which Bug 1755736 kept deliberately for files that share a name.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 2070932 - Identify the ember app's router.js by URL, r=#devtools-reviewers.

Four original sources on the ember quickstart page are named router.js, three of
them from vendor.js, and findSource() returns the first one in insertion order.
When vendor.map is processed before quickstart.map the test picks
ember-routing/services/router.js, whose line 13 is a comment, so addBreakpoint()
never dispatches SET_BREAKPOINT and the helper waits until the test times out.

Naming a source by its full URL is the case Bug 1755736 kept URL support for
when it narrowed findSource() to an exact file-name match.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8987e9a119c5
https://hg.mozilla.org/integration/autoland/rev/4e7ff632efec
Identify the ember app's router.js by URL, r=devtools-reviewers,ochameau.

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/4e7ff632efec