2070933 - An uncleared throwing setInterval in xbundle.js defeats the browser-chrome test timeout

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Florian Quèze [:florian]]

devtools/client/debugger/test/mochitest/examples/sourcemaps-with-sections/xbundle.js is, in full, a setInterval that throws every second with nothing clearing it. Ten tests load the fixture page that pulls it in, and only browser_dbg-breakpoints-sourcemap-with-sections.js wants the timer. The other nine take a thrown error every second while their tab is open.

That error defeats the harness timeout. browser-test.js extends a test by up to ten further windows as long as console output stays fresh, and every console-service message stamps lastOutputTime. A 1 Hz uncaught error keeps that freshness check passing forever, so a hung test burns every extension instead of failing after one.

The fix is to move xbundle.js to its own fixture page and point the one test that needs it there.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 2070933 - Give the sectioned-source-map test its own page, r=#devtools-reviewers.

Only browser_dbg-breakpoints-sourcemap-with-sections.js needs xbundle.js's
uncleared throwing setInterval; the nine other tests that load
doc-sourcemaps.html inherit it. Its output keeps lastOutputTime fresh, so
browser-test.js reads a hung test as merely slow and grants it every
MAX_UNEXPECTED_TIMEOUTS extension instead of failing it after one window.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f002e44b0066
https://hg.mozilla.org/integration/autoland/rev/7013be0e11f3
Give the sectioned-source-map test its own page, r=devtools-reviewers,nchevobbe.

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7013be0e11f3