Closed Bug 2070950 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62523 - VT: Abort transition when scope disconnects or loses LayoutObject.

Tracking

()

Status:

RESOLVED FIXED

Milestone:

158 Branch

Tracking Flags:

Tracking

Status

firefox158

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 months ago

Sync web-platform-tests PR 62523 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62523
Details from upstream follow.

Vladimir Levin <vmpstr@chromium.org> wrote:

VT: Abort transition when scope disconnects or loses LayoutObject.

This patch ensures that we are robust when the scope disconnects or
loses the layout object. It reuses the unsupported capture check and
updates that a little bit, since any time an unsupported condition
starts to apply, we should abort the transition

R=kevers@chromium.org, freedebreuil@google.com

Bug: 553293786
Change-Id: Ic1440216070787d5e1513f5cb6d30dabe67bde9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8323527
Reviewed-by: Kevin Ellis \<kevers@chromium.org>
Commit-Queue: Vladimir Levin \<vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1694584}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 months ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ce3706dacc1ff4da4517639a1fa721d7154816b

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 months ago

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 73 tests

Status Summary

Firefox

OK : 3[GitHub] 26[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 5
FAIL : 13[GitHub] 46[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 65[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 1[GitHub] 11[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 2
PASS : 8
CRASH : 2

Safari

OK : 3
FAIL : 13
TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-view-transitions/scoped/crashtests/container-query.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/display-change-after-capture.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/display-change-contents-after-capture.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/element-moved-to-new-document.html [wpt.fyi]: TIMEOUT (Chrome: CRASH, Safari: TIMEOUT)
/css/css-view-transitions/scoped/crashtests/first-letter-pseudo.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/implicit-stacking-context.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/mask-image.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/participating-scope.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/shadow-dom.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/shuffle.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/crashtests/zindex-part.html [wpt.fyi]: TIMEOUT
/css/css-view-transitions/scoped/auto-name-on-descendant.html [wpt.fyi]
- Scoped view transition with name auto on the scoped element: FAIL
/css/css-view-transitions/scoped/auto-name.html [wpt.fyi]
- Scoped view transition with name auto on the scoped element: FAIL
/css/css-view-transitions/scoped/callback-order.tentative.html [wpt.fyi]
- View transition DOM callbacks triggered in creation order.: FAIL
/css/css-view-transitions/scoped/capture.html [wpt.fyi]
- View-transition pseudo elements created for correct element: FAIL
- Capture with concurrent scoped view-transitions: FAIL
/css/css-view-transitions/scoped/collision.html [wpt.fyi]
- collision: FAIL
/css/css-view-transitions/scoped/display-inline-block.html [wpt.fyi]
- Scoped view transition on an inline-block element: FAIL
/css/css-view-transitions/scoped/display-none-during-transition.html [wpt.fyi]
- Display none during a view transition skips the transition.: FAIL
/css/css-view-transitions/scoped/document-element-start-view-transition.html [wpt.fyi]
- Synchronously starting a view transition on document.documentElement skips the previously active document view transition.: FAIL
- Synchronously starting a view transition on document skips the previously active view transition on document.documentElement.: FAIL
/css/css-view-transitions/scoped/element-active-view-transition.html [wpt.fyi]
- document.activeViewTransition returns the active transition: FAIL
/css/css-view-transitions/scoped/element-moved-to-new-document.html [wpt.fyi]
- moving scope element to new document via appendChild skips transition and rejects ready: FAIL (Safari: FAIL)
- adopting scope element to new document via adoptNode skips transition and rejects ready: FAIL (Safari: FAIL)
- moving ancestor of scope element to new document skips transition and rejects ready: FAIL (Safari: FAIL)
- removing scope element from document skips transition and rejects ready: FAIL (Safari: FAIL)
- removing ancestor of scope element from document skips transition and rejects ready: FAIL (Safari: FAIL)
/css/css-view-transitions/scoped/element-scoped-containment-invalid-state.html [wpt.fyi]
- startViewTransition on non-atomic inline (span) rejects ready with InvalidStateError: FAIL
- startViewTransition on display: contents rejects ready with InvalidStateError: FAIL
- startViewTransition on display: none rejects ready with InvalidStateError: FAIL
- startViewTransition on table row (internal table element) rejects ready with InvalidStateError: FAIL
- Element-scoped view transition is aborted if style changes to preclude layout containment: FAIL
/css/css-view-transitions/scoped/fill-forwards.html [wpt.fyi]
- View transition animations do not persist once the transition is finished even if animation-fill-mode is forwards: FAIL
/css/css-view-transitions/scoped/hit-test-vt-overlay.html [wpt.fyi]
- hit-test-vt-overlay: FAIL
/css/css-view-transitions/scoped/hit-testing.html [wpt.fyi]
- A view-transition participant is not a valid target for hit testing: FAIL
/css/css-view-transitions/scoped/missing-view-transition-name.html [wpt.fyi]
- Scoped view transition excludes animations for root element: FAIL
/css/css-view-transitions/scoped/negative-playback-rate.html [wpt.fyi]
- View transition duration affected by playback rate: FAIL
/css/css-view-transitions/scoped/run_in_parallel.html [wpt.fyi]
- Concurrent transition keeps running after transition skipped: FAIL
- Concurrent transition keeps running after transition finished: FAIL
- Concurrent transition keeps running after transition canceled: FAIL
/css/css-view-transitions/scoped/scope-containment-during-capture.html [wpt.fyi]
- Ensure scoped view transition elements apply internal size containment during the capture and DOM callback phases: FAIL
/css/css-view-transitions/scoped/scope-containment-sibling-offset.html [wpt.fyi]
- Sibling layout positions are preserved during the DOM callback due to scope size containment: FAIL
/css/css-view-transitions/scoped/scope-display-none.html [wpt.fyi]
- Scope with named child becoming display: none during update callback skips transition and rejects ready: FAIL (Chrome: PASS, Safari: FAIL)
- Scope with named child becoming display: none during animation skips transition: FAIL (Chrome: PASS, Safari: FAIL)
- Named scope becoming display: none during update callback skips transition and rejects ready: FAIL (Chrome: PASS, Safari: FAIL)
- Named scope becoming display: none during animation skips transition: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-view-transitions/scoped/scope-during-transition-1.html [wpt.fyi]
- view-transition-scope updated to all during transition and reset after finishing the transition: FAIL
- view-transition-scope updated to all during transition and reset after aborting the transition: FAIL
- Auto-reset of "view-transition-scope: all" does not clobber an explicitly set value: FAIL
/css/css-view-transitions/scoped/start-view-transition-on-disconnected-element.html [wpt.fyi]
- startViewTransition without callback on disconnected element immediately skips and rejects ready: FAIL (Chrome: PASS, Safari: FAIL)
- startViewTransition with callback on disconnected element runs callback, resolves finished, and rejects ready: FAIL (Chrome: PASS, Safari: FAIL)
- startViewTransition with failing callback on disconnected element rejects finished with callback error: FAIL (Chrome: PASS, Safari: FAIL)
- startViewTransition on element in disconnected subtree immediately skips and rejects ready: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-view-transitions/scoped/start-view-transition.html [wpt.fyi]
- start-view-transition: FAIL
/css/css-view-transitions/scoped/view-transition-scope-added-during-callback.html [wpt.fyi]
- Setting view-transition-scope to auto blocks propagation of name discovery.: FAIL
/css/css-view-transitions/scoped/view-transition-scope-display-contents.html [wpt.fyi]
- Setting view-transition-scope to auto blocks propagation of name discovery.: FAIL
/css/css-view-transitions/scoped/view-transition-scope-name-discovery.html [wpt.fyi]
- Setting view-transition-scope to auto blocks propagation of name discovery.: FAIL
/css/css-view-transitions/scoped/auto-nesting.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/clip-on-target-in-callback-2.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/clip-on-target-in-callback.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/display-change-during-transition.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/ink-overflow-on-target.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/scope-containment-pseudo-border.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/scope-during-transition-2.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/scrolled-target-position-rtl.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/scrolled-target-position.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/shadow-dom.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/target-in-scrolled-container.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/transform-clip.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/active-pseudo.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/ancestor-display-change.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/box-decoration-painting.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/centered-paint-offset.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/clipper-non-containing-block.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/display-change.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/fractional-border-shift.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/from-scale-zero.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/implicit-contain.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/nested-scope.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/new-content.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/old-content.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/overflow-excludes-pseudo.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/paint-order.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/pause-rendering-resize.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/pause-rendering.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/rotation-on-scoped-element.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/scroller-with-child.html [wpt.fyi]: FAIL
/css/css-view-transitions/scoped/to-scale-zero.html [wpt.fyi]: FAIL

Tests Disabled in Gecko Infrastructure

/css/css-view-transitions/scoped/auto-nesting.html [wpt.fyi]: SKIP linked bug:Bug 2020860
/css/css-view-transitions/scoped/clip-on-target-in-callback-2.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/clip-on-target-in-callback.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/display-change-during-transition.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/ink-overflow-on-target.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/scope-containment-pseudo-border.html [wpt.fyi]: SKIP linked bug:Bug 2057332
/css/css-view-transitions/scoped/scope-during-transition-2.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/scrolled-target-position-rtl.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/scrolled-target-position.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/shadow-dom.html [wpt.fyi]: SKIP
/css/css-view-transitions/scoped/target-in-scrolled-container.html [wpt.fyi]: SKIP linked bug:Bug 2002311
/css/css-view-transitions/scoped/transform-clip.html [wpt.fyi]: SKIP

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Blocks: 2071100

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 2071508

Pulsebot

Comment 3

•

2 months ago

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fa6622ebfe92 https://hg.mozilla.org/integration/autoland/rev/48f02795fb42 [wpt PR 62523] - VT: Abort transition when scope disconnects or loses LayoutObject., a=testonly https://github.com/mozilla-firefox/firefox/commit/8d20ec199fb0 https://hg.mozilla.org/integration/autoland/rev/5f5477d12479 [wpt PR 62523] - Update wpt metadata, a=testonly

Goloman Adrian[:agoloman]

Comment 4

•

2 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/48f02795fb42
https://hg.mozilla.org/mozilla-central/rev/5f5477d12479

Status: NEW → RESOLVED

Closed: 2 months ago

status-firefox158: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 158 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 62523 - VT: Abort transition when scope disconnects or loses LayoutObject.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Updated

Updated

Comment 3

Comment 4