[wpt-sync] Sync PR 62592 - Do not cache failed module imports
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62592 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62592
Details from upstream follow.
Yoav Weiss <yoavweiss@chromium.org> wrote:
Do not cache failed module imports
Implements https://github.com/whatwg/html/pull/10327 behind a flag to
enable developers to retry failed module loads. It does so by removing
module map entries from the map in case of a failure.The test changes delete failing expectations and fix test flakiness
that resulted from a hardcoded UUID, by moving the tests to use a
generated UUID (which requires .https serving for the test, and .sub
serving for its resources).Bug: 534781954
Change-Id: I4b97894cfcfa6878077cd8a933ca54fdca0466e9
Binary-Size: +12B is the generated base::Feature for new runtime flag.
Reviewed-on: https://chromium-review.googlesource.com/8102202
WPT-Export-Revision: 01ffb4d7edbd9f0fe7c6f3d70fe1b34693824ab4
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee2a9ca847c993e59707425b3b8f222a1998fc23
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 140 tests
Status Summary
Firefox
OK : 2[GitHub] 134[Gecko-android-em-14-x86_64-debug-geckoview] 135[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 2[GitHub] 439[Gecko-android-em-14-x86_64-debug-geckoview] 442[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 11
ERROR: 3
Chrome
OK : 2
FAIL : 2
Safari
OK : 2
FAIL : 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/semantics/scripting-1/the-script-element/module/instantiation-error-8.html [wpt.fyi]:
SKIP - /html/semantics/scripting-1/the-script-element/module/choice-of-error-1.html [wpt.fyi]
- Parse errors in different files should be reported depending on different roots:
FAIL
- Parse errors in different files should be reported depending on different roots:
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url.sub.html [wpt.fyi]
- Relative URL-like from cross origin classic <script> without crossorigin attribute:
FAIL
- Relative URL-like from cross origin classic <script> without crossorigin attribute:
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/basic-deferred-evaluation.tentative.html [wpt.fyi]:
ERROR - /html/semantics/scripting-1/the-script-element/module/dynamic-import/cyclic-tla-defer-eval.tentative.html [wpt.fyi]:
ERROR - /html/semantics/scripting-1/the-script-element/module/dynamic-import/delay-load-event.html [wpt.fyi]
- Dynamic imports don't delay the load event.:
FAIL
- Dynamic imports don't delay the load event.:
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials-setTimeout.sub.html [wpt.fyi]
- Cross-origin dynamic import from setTimeout(string) from classic script (crossOrigin=use-credentials):
FAIL
- Cross-origin dynamic import from setTimeout(string) from classic script (crossOrigin=use-credentials):
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials.sub.html [wpt.fyi]
- Cross-origin dynamic import from classic script (crossOrigin=use-credentials):
FAIL
- Cross-origin dynamic import from classic script (crossOrigin=use-credentials):
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error.html [wpt.fyi]
- import() must reject with the same error object for each import when there is a bad module specifier in a dependency:
FAIL
- import() must reject with the same error object for each import when there is a bad module specifier in a dependency:
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/microtasks/basic.any.html [wpt.fyi]
- import() should not drain the microtask queue when loading an already loaded module:
FAIL
- import() should not drain the microtask queue when loading an already loaded module:
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/string-compilation-of-promise-result.html [wpt.fyi]
- Evaled the script via eval, successful import:
FAIL - Evaled the script via Function, successful import:
FAIL
- Evaled the script via eval, successful import:
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/tla-deferred-evaluation.tentative.html [wpt.fyi]:
ERROR - /html/semantics/scripting-1/the-script-element/module/error-type-1.html [wpt.fyi]
- network error has higher priority than parse error:
FAIL
- network error has higher priority than parse error:
- /html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.any.worker-module.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/scripting-1/the-script-element/module/modulepreload-inline-referrerpolicy.html [wpt.fyi]
- Inline modulepreload elements should respect the referrerpolicy attribute:
FAIL
- Inline modulepreload elements should respect the referrerpolicy attribute:
- /html/semantics/scripting-1/the-script-element/module/dynamic-import/microtasks/worklet.https.html [wpt.fyi]:
SKIP
Tests Disabled in Gecko Infrastructure
- /html/semantics/scripting-1/the-script-element/module/instantiation-error-8.html [wpt.fyi]:
SKIP - /html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.any.worker-module.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/scripting-1/the-script-element/module/dynamic-import/microtasks/worklet.https.html [wpt.fyi]:
SKIPlinked bug:Bug 1797357
Comment 4•2 months ago
|
||
| bugherder | ||
Description
•