[wpt-sync] Sync PR 62586 - Incorrect cast to CSSSuperellipseValue
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
|
82.28 KB,
text/plain
|
Details |
Sync web-platform-tests PR 62586 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62586
Details from upstream follow.
Rune Lillesveen <futhark@chromium.org> wrote:
Incorrect cast to CSSSuperellipseValue
CSSValue for shape might be an identifier different from 'round'. We did
a cast to CSSSuperEllipseValue which caused a crash.Use DynamicTo\<> instead.
Bug: 558810287
Change-Id: Id647df72ed070a06d650b5cdc4d415e66e6bf41f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8378406
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1695245}
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=37badd68f7c9f64ace9190f1c6e5412cde62a091
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 148 tests
Status Summary
Firefox
OK : 2[GitHub] 19[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 878[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 890[Gecko-linux2404-64-debug] 973[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 36[GitHub] 107[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 140[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 223[Gecko-linux2404-64-debug]
Chrome
OK : 1
PASS : 24
CRASH: 1
Safari
OK : 2
FAIL : 36
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
(See attachment for full changes)
Comment 4•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cc1d98633bdd
https://hg.mozilla.org/mozilla-central/rev/7cfdfc56d1f1
Description
•