Closed Bug 2071061 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62572 - Compare pointer-valued properties by value in CSSPropertyEquality

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62572 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62572
Details from upstream follow.

Sam Attard <samuel.r.attard@gmail.com> wrote:

Compare pointer-valued properties by value in CSSPropertyEquality

Several properties (scrollbar-color, quotes, marker-*, list-style-type,
view-transition-name/class, font-feature-settings,
font-variant-alternates) were compared with == on a pointer, so two
computed styles built from the same declarations compared unequal and
transitions could start between identical values. Use
base::ValuesEquivalent() for them.

Also store nullptr for font-feature-settings: normal and no tree scope
for the non-overridable list-style-type keywords, so that declared
values compare equal to the corresponding initial/UA values.

Bug: 558028324
Change-Id: Ib3d8efb11c9e507947f2ab304721f668207c06b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8360638
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Samuel Attard \<samuel.r.attard@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1695023}

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 366 tests

Status Summary

Firefox

OK : 3[GitHub] 150[Gecko-android-em-14-x86_64-debug-geckoview] 151[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2[GitHub] 29[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 2299[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 2455[Gecko-android-em-14-x86_64-debug-geckoview] 2458[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 2460[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 1[GitHub] 65[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 81[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 83[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 3
PASS: 1
FAIL: 2

Safari

OK : 3
PASS: 2
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-transitions/CSSTransition-startTime.tentative.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview]
  • /css/css-transitions/before-load-001.html [wpt.fyi]: SKIP
  • /css/css-transitions/properties-value-001.html [wpt.fyi]: SKIP
  • /css/css-transitions/properties-value-002.html [wpt.fyi]: SKIP
  • /css/css-transitions/properties-value-003.html [wpt.fyi]: SKIP
  • /css/css-transitions/properties-value-implicit-001.html [wpt.fyi]: SKIP
  • /css/css-transitions/properties-value-inherit-001.html [wpt.fyi]: SKIP
  • /css/css-transitions/properties-value-inherit-002.html [wpt.fyi]: SKIP
  • /css/css-transitions/properties-value-inherit-003.html [wpt.fyi]: SKIP
  • /css/css-transitions/pseudo-elements-001.html [wpt.fyi]: SKIP
  • /css/css-lists/animations/list-style-image-interpolation.html [wpt.fyi]
    • CSS Transitions: property <list-style-image> from neutral to [url(../resources/stripes-20.png)] at (-0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from neutral to [url(../resources/stripes-20.png)] at (0) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from neutral to [url(../resources/stripes-20.png)] at (0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from neutral to [url(../resources/stripes-20.png)] at (-0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from neutral to [url(../resources/stripes-20.png)] at (0) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from neutral to [url(../resources/stripes-20.png)] at (0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [initial] to [url(../resources/stripes-20.png)] at (-0.3) should be [none]: FAIL
    • CSS Transitions: property <list-style-image> from [initial] to [url(../resources/stripes-20.png)] at (0) should be [none]: FAIL
    • CSS Transitions: property <list-style-image> from [initial] to [url(../resources/stripes-20.png)] at (0.3) should be [none]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [initial] to [url(../resources/stripes-20.png)] at (-0.3) should be [none]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [initial] to [url(../resources/stripes-20.png)] at (0) should be [none]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [initial] to [url(../resources/stripes-20.png)] at (0.3) should be [none]: FAIL
    • CSS Transitions: property <list-style-image> from [inherit] to [url(../resources/stripes-20.png)] at (-0.3) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [inherit] to [url(../resources/stripes-20.png)] at (0) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [inherit] to [url(../resources/stripes-20.png)] at (0.3) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [inherit] to [url(../resources/stripes-20.png)] at (-0.3) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [inherit] to [url(../resources/stripes-20.png)] at (0) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [inherit] to [url(../resources/stripes-20.png)] at (0.3) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [unset] to [url(../resources/stripes-20.png)] at (-0.3) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [unset] to [url(../resources/stripes-20.png)] at (0) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [unset] to [url(../resources/stripes-20.png)] at (0.3) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [unset] to [url(../resources/stripes-20.png)] at (-0.3) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [unset] to [url(../resources/stripes-20.png)] at (0) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [unset] to [url(../resources/stripes-20.png)] at (0.3) should be [url(../resources/blue-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [none] to [url(../resources/stripes-20.png)] at (-0.3) should be [none]: FAIL
    • CSS Transitions: property <list-style-image> from [none] to [url(../resources/stripes-20.png)] at (0) should be [none]: FAIL
    • CSS Transitions: property <list-style-image> from [none] to [url(../resources/stripes-20.png)] at (0.3) should be [none]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [none] to [url(../resources/stripes-20.png)] at (-0.3) should be [none]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [none] to [url(../resources/stripes-20.png)] at (0) should be [none]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [none] to [url(../resources/stripes-20.png)] at (0.3) should be [none]: FAIL
    • CSS Transitions: property <list-style-image> from [url(../resources/green-20.png)] to [url(../resources/stripes-20.png)] at (-0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [url(../resources/green-20.png)] to [url(../resources/stripes-20.png)] at (0) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [url(../resources/green-20.png)] to [url(../resources/stripes-20.png)] at (0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [url(../resources/green-20.png)] to [url(../resources/stripes-20.png)] at (-0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [url(../resources/green-20.png)] to [url(../resources/stripes-20.png)] at (0) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [url(../resources/green-20.png)] to [url(../resources/stripes-20.png)] at (0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [url(../resources/green-20.png)] to [linear-gradient(45deg, blue, orange)] at (-0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [url(../resources/green-20.png)] to [linear-gradient(45deg, blue, orange)] at (0) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [url(../resources/green-20.png)] to [linear-gradient(45deg, blue, orange)] at (0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [url(../resources/green-20.png)] to [linear-gradient(45deg, blue, orange)] at (-0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [url(../resources/green-20.png)] to [linear-gradient(45deg, blue, orange)] at (0) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [url(../resources/green-20.png)] to [linear-gradient(45deg, blue, orange)] at (0.3) should be [url(../resources/green-20.png)]: FAIL
    • CSS Transitions: property <list-style-image> from [linear-gradient(-45deg, red, yellow)] to [linear-gradient(45deg, blue, orange)] at (-0.3) should be [linear-gradient(-45deg, red, yellow)]: FAIL
    • CSS Transitions: property <list-style-image> from [linear-gradient(-45deg, red, yellow)] to [linear-gradient(45deg, blue, orange)] at (0) should be [linear-gradient(-45deg, red, yellow)]: FAIL
    • CSS Transitions: property <list-style-image> from [linear-gradient(-45deg, red, yellow)] to [linear-gradient(45deg, blue, orange)] at (0.3) should be [linear-gradient(-45deg, red, yellow)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [linear-gradient(-45deg, red, yellow)] to [linear-gradient(45deg, blue, orange)] at (-0.3) should be [linear-gradient(-45deg, red, yellow)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [linear-gradient(-45deg, red, yellow)] to [linear-gradient(45deg, blue, orange)] at (0) should be [linear-gradient(-45deg, red, yellow)]: FAIL
    • CSS Transitions with transition: all: property <list-style-image> from [linear-gradient(-45deg, red, yellow)] to [linear-gradient(45deg, blue, orange)] at (0.3) should be [linear-gradient(-45deg, red, yellow)]: FAIL
  • /css/css-lists/list-style-type-transition-tree-scope-custom-ident.html [wpt.fyi]
    • Transition when an author-defined list-style-type moves to another tree scope: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-transitions/after-change-style-inherited-try-fallback.html [wpt.fyi]
    • Position fallback correctly applied to after-change style: FAIL
  • /css/css-transitions/idlharness-2.html [wpt.fyi]
    • Partial interface TransitionEvent: original interface defined: FAIL
    • Partial dictionary TransitionEventInit: original dictionary defined: FAIL
  • /css/css-transitions/starting-style-size-container.html [wpt.fyi]
    • Triggered transition from first style update based on up-to-date container query: FAIL
  • /css/css-transitions/unregistered-custom-property-transition.html [wpt.fyi]
    • first value -> unset transition with allow-discrete: FAIL
  • /css/css-transitions/animations/animate-with-color-mix.html [wpt.fyi]
    • Transition from color-mix to legacy rgb: FAIL
    • Transition from legacy rgb to color-mix: FAIL
    • Transition from color-mix to srgb: FAIL
    • Transition from srgb to color-mix: FAIL
    • Transition from color-mix with transparency to legacy rgba: FAIL
    • Transition from legacy rgba to color-mix with transparency: FAIL
  • /css/css-transitions/parsing/transition-timing-function-computed.html [wpt.fyi]
    • Property transition-timing-function value 'steps(calc(2 * sibling-index()), jump-none)': FAIL
    • Property transition-timing-function value 'steps(sibling-index(), jump-none)': FAIL
    • Property transition-timing-function value 'steps(calc(2 * sign(1em - 1000px)), jump-none)': FAIL
    • Property transition-timing-function value 'steps(calc(2 * sign(1em - 1000px)), start)': FAIL
  • /css/css-transitions/parsing/transition-timing-function-valid.html [wpt.fyi]
    • e.style['transition-timing-function'] = "steps(sibling-index(), jump-none)" should set the property value: FAIL
  • /css/css-lists/counter-001.html [wpt.fyi]: FAIL
  • /css/css-lists/counter-002.html [wpt.fyi]: FAIL
  • /css/css-lists/counter-003.html [wpt.fyi]: FAIL
  • /css/css-lists/counter-list-item-2.html [wpt.fyi]: FAIL
  • /css/css-lists/counter-list-item.html [wpt.fyi]: FAIL [Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
  • /css/css-lists/counters-001.html [wpt.fyi]: FAIL
  • /css/css-lists/counters-002.html [wpt.fyi]: FAIL
  • /css/css-lists/counters-003.html [wpt.fyi]: FAIL
  • /css/css-lists/counters-004.html [wpt.fyi]: FAIL
  • /css/css-lists/counters-scope-001.html [wpt.fyi]: FAIL
  • /css/css-lists/counters-scope-002.html [wpt.fyi]: FAIL
  • /css/css-lists/counters-scope-003.html [wpt.fyi]: FAIL
  • /css/css-lists/counters-scope-004.html [wpt.fyi]: FAIL
  • /css/css-lists/foo-counter-reversed-007a.html [wpt.fyi]: FAIL
  • /css/css-lists/foo-counter-reversed-007b.html [wpt.fyi]: FAIL
  • /css/css-lists/foo-counter-reversed-009a.html [wpt.fyi]: FAIL
  • /css/css-lists/foo-counter-reversed-009b.html [wpt.fyi]: FAIL
  • /css/css-lists/list-marker-with-lineheight-and-overflow-hidden-001.html [wpt.fyi]: FAIL [Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.