Closed Bug 2071130 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62577 - Invalidate shapes' percentage 'stroke-dasharray' on viewport resize

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
158 Branch
Tracking Flags:
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62577 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62577
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Invalidate shapes' percentage 'stroke-dasharray' on viewport resize

We previously only consider 'stroke-width' as depending on the viewport,
but the same should apply for 'stroke-dasharray'.

Add an additional case to the ComputeStrokeHasRelativeLengths() helper,
and also move to using a bit to track the result of this function, since
it's now potentially more costly - but can easily be tracked when
computed style changes.

Fixed: 557807412
Change-Id: Ic07c73e62110a9832f3e0ff35c64325a336d3ef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8361775
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Commit-Queue: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1695413}

Component: web-platform-tests → SVG
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 60 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3[GitHub] 44[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 15[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 16[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

FAIL: 3

Safari

PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/93cd689b2a8f https://hg.mozilla.org/integration/autoland/rev/bd1521c2940a [wpt PR 62577] - Invalidate shapes' percentage 'stroke-dasharray' on viewport resize, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bd1521c2940a

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox158: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch

Authored by Fredrik Söderquist
https://github.com/mozilla/enterprise-firefox/commit/93cd689b2a8f6af66eab6798577e720434150699
[enterprise-main] Bug 2071130 [wpt PR 62577] - Invalidate shapes' percentage 'stroke-dasharray' on viewport resize, a=testonly

You need to log in before you can comment on or make changes to this bug.