2071135 - [wpt-sync] Sync PR 62598 - [npw] Support start delay for bg-color on the compositor thread

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 62598 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62598
Details from upstream follow.

Kevin Ellis <[e-mail]> wrote:

[npw] Support start delay for bg-color on the compositor thread

Aside from removing the fallback reason, an additional fix was needed
to suppress short-circuiting of paint invalidation when bg-color
changes while the composited animation is not in effect. We need
paint invalidation in this case to pick up the new underlying value.

Change-Id: I29ddbe69703401cd3eb9e87040e23b56efaa3bee

Reviewed-on: https://chromium-review.googlesource.com/8295942
WPT-Export-Revision: 3e51e425cde34f893a6b773229296cf59ee9eab1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfeddf9c15325ea8172e3f78209992f69063c573

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 204 tests

Status Summary

Firefox

OK : 126
PASS : 1[GitHub] 45[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1423[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1450[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-64-25h2-debug] 1451[Gecko-linux2404-64-debug] 1452[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt]
FAIL : 31[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 34[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR: 1[Gecko-linux2404-64-debug] 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-64-25h2-debug]

Chrome

PASS : 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-animations/KeyframeEffect-getKeyframes.tentative.html [wpt.fyi]
  • KeyframeEffect.getKeyframes() returns expected frames for an animation with multiple keyframes for the same time and with different easing functions and composite operations: FAIL
  • KeyframeEffect.getKeyframes() returns expected values for animations with a CSS variable which is overriden by the value in keyframe: FAIL
  • KeyframeEffect.getKeyframes() returns expected values for animations with only custom property in a keyframe: FAIL
• /css/css-animations/animate-with-background-color-oklch-002.html [wpt.fyi]
  • Animate from legacy rgb to oklch: FAIL
  • Animate from legacy rgb to color-mix oklch: FAIL
• /css/css-animations/animate-with-color-mix-2.html [wpt.fyi]
  • animate-with-color-mix-2: FAIL
• /css/css-animations/animate-with-color-mix.html [wpt.fyi]
  • Animate from neutral keyframe with color-mix to legacy rgb: FAIL
  • Animate from legacy rgb to neutral keyframe with color-mix: FAIL
  • Animate from neutral keyframe with color-mix to srgb: FAIL
  • Animate from srgb to neutral keyframe with color-mix: FAIL
  • Animate from color-mix with transparency to legacy rgba: FAIL
  • Animate from legacy rgba to color-mix with transparency: FAIL
• /css/css-animations/animate-with-relative-color.html [wpt.fyi]
  • Animate from absolute oklch to relative oklch: FAIL
  • Animate from color keyword to relative rgb: FAIL
• /css/css-animations/parsing/keyframe-selectors.html [wpt.fyi]
  • 'calc(10%)' should be a valid keyframe selector: FAIL
  • 'calc(10% * sibling-index())' should be a valid keyframe selector: FAIL
  • 'calc(10% * sign(1em - 1px))' should be a valid keyframe selector: FAIL
  • 'entry calc(10%)' should be a valid keyframe selector: FAIL
  • 'exit calc(60%)' should be a valid keyframe selector: FAIL
• /css/css-animations/parsing/keyframes-allowed-properties.html [wpt.fyi]
  • @keyframes allows all non-animation properties and animation-timing-function: FAIL
• /css/css-animations/cancel-events-on-remove.html [wpt.fyi]
  • Re-parenting: animationcancel is fired asynchronously: FAIL
• /css/css-animations/display-none-dont-cancel-pseudo.tentative.html [wpt.fyi]
  • A CSS Animation on a pseudo-element animating to "display: none" with "fill: forwards" remains active after animation completion.: FAIL
• /css/css-animations/responsive/column-rule-color-001.html [wpt.fyi]
  • column-rule-color responds to inherited changes: FAIL
• /css/css-animations/responsive/column-width-001.html [wpt.fyi]
  • column-width responds to inherited changes: FAIL
• /css/css-animations/responsive/fill-forwards-viewport-units.html [wpt.fyi]
  • fill: forwards with viewport units updates on viewport resize: FAIL
• /css/css-animations/event-dispatch.tentative.html [wpt.fyi]
  • Replacing a running animation should get animationcancel earlier than animationstart: FAIL
  • The cancel event should be fired before the new start event if both have the same position in the animation list: FAIL
• /css/css-animations/revert-rule-keyframes-dynamic.html [wpt.fyi]
  • revert-rule in keyframes, reverted-to value changing (standard property): FAIL
  • revert-rule in keyframes, reverted-to value changing (custom property): FAIL
• /css/css-animations/revert-rule-keyframes.html [wpt.fyi]
  • revert-rule in keyframes (width): FAIL
  • revert-rule in keyframes (--x): FAIL
• /css/css-animations/animation-delay-010.html [wpt.fyi]: SKIP
• /css/css-animations/animation-delay-012.html [wpt.fyi]: ERROR [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-linux2404-64-debug, Gecko-windows11-64-25h2-debug], PASS [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt]
• /css/css-animations/animation-duration-infinite.html [wpt.fyi]: ERROR [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-64-25h2-debug], PASS [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt]
• /css/css-animations/animation-important-002.html [wpt.fyi]: FAIL
• /css/css-animations/animation-name-in-nested-shadow.html [wpt.fyi]: FAIL
• /css/css-animations/animation-name-in-shadow-part-outer-match.html [wpt.fyi]: FAIL

Tests Disabled in Gecko Infrastructure

• /css/css-animations/animation-delay-010.html [wpt.fyi]: SKIP

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/21b66aaa8c32
https://hg.mozilla.org/integration/autoland/rev/41f5cf74e6e3
[wpt PR 62598] - [npw] Support start delay for bg-color on the compositor thread, a=testonly

Comment 4

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/41f5cf74e6e3