Closed Bug 2071157 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62604 - animation: Fix step-easing limit direction for reversed animations

Categories

(Core :: DOM: Animation, task, P4)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62604 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62604
Details from upstream follow.

Zhou Shuangshuang <shuangshuang.zhou@intel.com> wrote:

animation: Fix step-easing limit direction for reversed animations

KeyframeEffect::ApplyEffects and InertEffect::Sample picked the
before/after limit from phase alone, ignoring playback direction.
TimingCalculations::CalculateTransformedProgress already computes
this correctly; extracted it into LimitDirectionForPhase() and
pointed both call sites at it. This needed threading the (already
computed, previously discarded) current-direction-forward bit
through Timing::CalculatedTiming.

compositor_animation_curve.cc:184 has the same bug but is tracked
separately (crbug.com/347958668), blocked on start-delay support;
left alone.

Added a WPT covering both the after-phase (step-start) and
before-phase (step-end) cases with direction:reverse. Confirmed on
stable Chrome that both fail without this patch (wrong computed
opacity at the discontinuity). Also confirmed both pass on Firefox
Nightly, i.e. the asserted values are real interoperable behavior,
not a Chromium-specific interpretation of the spec.

Bug: 347967022
Change-Id: I7bf7fa6506432ec15ae21e8b7074d7e8d9f6caad

Reviewed-on: https://chromium-review.googlesource.com/8369420
WPT-Export-Revision: d0459b2ce8bbb31e764c1f4a3500c3f1e7793987

Component: web-platform-tests → DOM: Animation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 16 tests

Status Summary

Firefox

OK : 1[GitHub] 11[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 100[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 102[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 103[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5c04602900a6 https://hg.mozilla.org/integration/autoland/rev/714d0cde3d91 [wpt PR 62604] - animation: Fix step-easing limit direction for reversed animations, a=testonly
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.