[wpt-sync] Sync PR 62604 - animation: Fix step-easing limit direction for reversed animations
Categories
(Core :: DOM: Animation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62604 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62604
Details from upstream follow.
Zhou Shuangshuang <shuangshuang.zhou@intel.com> wrote:
animation: Fix step-easing limit direction for reversed animations
KeyframeEffect::ApplyEffects and InertEffect::Sample picked the
before/after limit from phase alone, ignoring playback direction.
TimingCalculations::CalculateTransformedProgress already computes
this correctly; extracted it into LimitDirectionForPhase() and
pointed both call sites at it. This needed threading the (already
computed, previously discarded) current-direction-forward bit
through Timing::CalculatedTiming.compositor_animation_curve.cc:184 has the same bug but is tracked
separately (crbug.com/347958668), blocked on start-delay support;
left alone.Added a WPT covering both the after-phase (step-start) and
before-phase (step-end) cases with direction:reverse. Confirmed on
stable Chrome that both fail without this patch (wrong computed
opacity at the discontinuity). Also confirmed both pass on Firefox
Nightly, i.e. the asserted values are real interoperable behavior,
not a Chromium-specific interpretation of the spec.Bug: 347967022
Change-Id: I7bf7fa6506432ec15ae21e8b7074d7e8d9f6caadReviewed-on: https://chromium-review.googlesource.com/8369420
WPT-Export-Revision: d0459b2ce8bbb31e764c1f4a3500c3f1e7793987
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe209e21db93965ee443f370796dda948651ae47
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 16 tests
Status Summary
Firefox
OK : 1[GitHub] 11[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 100[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 102[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 103[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
OK : 1
FAIL: 2
Safari
OK : 1
PASS: 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation.html [wpt.fyi]
- iteration composition of incompatible calc-size() bases (accumulation skipped at 0%, allowed at 50%):
FAIL - iteration composition of incompatible clip rects (accumulation skipped at 0%, allowed at 50%):
FAIL
- iteration composition of incompatible calc-size() bases (accumulation skipped at 0%, allowed at 50%):
- /web-animations/animation-model/keyframe-effects/transform-and-opacity-on-inline-001.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt]
Comment 4•2 months ago
|
||
| bugherder | ||
Description
•