Closed Bug 2071168 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62608 - [Gemma4 WPTs] Restrict decimal regex constraint in WPT to valid range

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox158 fixed)

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62608 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62608
Details from upstream follow.

Isaac Ahouma <iahouma@google.com> wrote:

[Gemma4 WPTs] Restrict decimal regex constraint in WPT to valid range

The prompt asks for a rating between -1.0 and 1.0, but the previous
regex constraint allowed numbers outside this range (e.g. 1.5, 3.8).
Because constrained decoding allows any tokens matching the regex, the
model occasionally produced valid floats outside [-1.0, 1.0], causing
the subsequent numerical assertions to fail.

Update the regex to strictly match the requested [-1.0, 1.0] range.

Bug: 547951465
Change-Id: I88f40973332c7edb1ca63e76f406c453500f4a68
Fixed: 547951465

Reviewed-on: https://chromium-review.googlesource.com/8390437
WPT-Export-Revision: 0e02a9e0621c563dc8df2fe60f5ea18c52f9ac1b

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 19 tests and 1 subtests

Status Summary

Firefox

OK : 1[GitHub] 19[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 1[GitHub] 19[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

TIMEOUT: 2

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d2fb6314b290 https://hg.mozilla.org/integration/autoland/rev/e67139bc5068 [wpt PR 62608] - [Gemma4 WPTs] Restrict decimal regex constraint in WPT to valid range, a=testonly
Status: REOPENED → RESOLVED
Closed: 2 months ago → 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.