Closed Bug 2071227 Opened 4 days ago Closed 3 days ago

The DevTools source editor's text area has no accessible name

Categories

(DevTools :: Source Editor, defect)

defect

Tracking

(firefox158 fixed)

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 2 open bugs)

Details

(Keywords: access)

Attachments

(1 file)

CodeMirror 6 gives the editor's content area role="textbox" but no accessible name, so a screen reader reaches an unnamed multiline text box. It also relies on contenteditable alone for focus, which leaves the element's tabIndex at -1 even though it is in the tab order.

editor.js can set both an aria-label and an explicit tabindex through CodeMirror's public contentAttributes facet, without regenerating the bundle. That covers every panel that mounts a CodeMirror 6 editor, and allows removing four fail-if = ["a11y_checks"] annotations in the debugger.

Blocks: 1849028

The contentAttributes facet is public, so this needs no bundle regeneration. The
name is overridable because not every consumer shows source code. The annotations
removed here were added by Bug 1849028.

Assignee: nobody → florian
Status: NEW → ASSIGNED
Pushed by fqueze@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f93d234739b5 https://hg.mozilla.org/integration/autoland/rev/61e229a57854 Give the DevTools CodeMirror 6 editors an accessible name, r=devtools-reviewers,bomsy.
Status: ASSIGNED → RESOLVED
Closed: 3 days ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch

The Bugbug bot thinks this bug is an accessibility bug, but please revert this change in case of error.

Keywords: access
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: