[wpt-sync] Sync PR 62544 - [css] Treat valueluess dynamic-range values as truthy
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62544 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62544
Details from upstream follow.
Kurt Catti-Schmidt <kschmi@microsoft.com> wrote:
[css] Treat valueluess dynamic-range values as truthy
The css/mediaqueries/dynamic-range WPT is actually incorrect in that it
treats empty dynamic-range values as falsy. This change updates the test
and the Chromium implementation to support this.Bug: 40775390
Change-Id: Icc2948c927a9ecaa197832cbadcbffa40e4223c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8340151
Commit-Queue: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1694671}
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c404badc8f1141002b4292f8536fa962476e08f
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 94 tests and 14 subtests
Status Summary
Firefox
OK : 1[GitHub] 30[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 21[GitHub] 1679[Gecko-windows11-32-25h2-opt] 1680[Gecko-windows11-32-25h2-debug] 1737[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 1738[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 2[GitHub] 47[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug] 48[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR : 5
NOTRUN: 41
Chrome
OK : 1
PASS : 19
FAIL : 4
Safari
OK : 1
PASS : 18
FAIL : 5
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/mediaqueries/device-aspect-ratio-003.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/mediaqueries/display-mode.tentative.html [wpt.fyi]
- Should be known: '(display-mode: unframed)':
FAIL - Should be known: '(display-mode: window-controls-overlay)':
FAIL
- Should be known: '(display-mode: unframed)':
- /css/mediaqueries/display-state.tentative.html [wpt.fyi]
- Should be known: '(display-state: normal)':
FAIL - Should be known: '(display-state: minimized)':
FAIL - Should be known: '(display-state: maximized)':
FAIL - Should be known: '(display-state: fullscreen)':
FAIL - Should be known: '(display-state)':
FAIL - Check that display-state evaluates to true in the boolean context:
FAIL
- Should be known: '(display-state: normal)':
- /css/mediaqueries/dynamic-range.html [wpt.fyi]
- Check that dynamic-range evaluates to true in the boolean context:
FAIL(Chrome:FAIL, Safari:PASS) - Check that video-dynamic-range evaluates to true in the boolean context:
FAIL(Chrome:FAIL, Safari:FAIL)
- Check that dynamic-range evaluates to true in the boolean context:
- /css/mediaqueries/mq-non-matching-lazy-load.tentative.html [wpt.fyi]
- Ensure browser renders the page without waiting for non matching @import style:
FAIL[Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug]
- Ensure browser renders the page without waiting for non matching @import style:
- /css/mediaqueries/navigation-controls.tentative.html [wpt.fyi]
- Should be known: '(navigation-controls)':
FAIL - Should be known: '(navigation-controls: none)':
FAIL - Should be known: '(navigation-controls: back-button)':
FAIL - Check that none evaluates to false in the boolean context:
FAIL
- Should be known: '(navigation-controls)':
- /css/mediaqueries/preferences-colorScheme.tentative.https.html [wpt.fyi]:
ERROR- navigator.preferences.colorScheme supported:
FAIL - navigator.preferences.colorScheme.override supported:
FAIL - navigator.preferences.colorScheme.value supported:
FAIL - navigator.preferences.colorScheme.validValues supported:
FAIL - navigator.preferences.colorScheme.requestOverride() with invalid value throws:
NOTRUN - navigator.preferences.colorScheme.override returns override value:
NOTRUN - navigator.preferences.colorScheme.requestOverride(null) works like clearOverride():
NOTRUN - navigator.preferences.colorScheme.requestOverride('') works like clearOverride():
NOTRUN - navigator.preferences.colorScheme.requestOverride() updates (prefers-color-scheme):
NOTRUN - navigator.preferences.colorScheme fires change event when requesting override:
FAIL - navigator.preferences.colorScheme fires change event when requesting override (without value change):
NOTRUN - navigator.preferences.colorScheme fires change event when clearing override:
NOTRUN - navigator.preferences.colorScheme fires change event when clearing override (without value change):
NOTRUN
- navigator.preferences.colorScheme supported:
- /css/mediaqueries/preferences-contrast.tentative.https.html [wpt.fyi]:
ERROR- navigator.preferences.contrast supported:
FAIL - navigator.preferences.contrast.override supported:
FAIL - navigator.preferences.contrast.value supported:
FAIL - navigator.preferences.contrast.validValues supported:
FAIL - navigator.preferences.contrast.requestOverride() with invalid value throws:
NOTRUN - navigator.preferences.contrast.requestOverride('custom') throws:
NOTRUN - navigator.preferences.contrast.clearOverride() works:
NOTRUN - navigator.preferences.contrast.requestOverride(null) works like clearOverride():
NOTRUN - navigator.preferences.contrast.requestOverride('') works like clearOverride():
NOTRUN - navigator.preferences.contrast.requestOverride() updates (prefers-contrast):
NOTRUN - navigator.preferences.contrast fires change event when requesting override:
FAIL - navigator.preferences.contrast fires change event when requesting override (without value change):
NOTRUN - navigator.preferences.contrast fires change event when clearing override:
NOTRUN - navigator.preferences.contrast fires change event when clearing override (without value change):
NOTRUN
- navigator.preferences.contrast supported:
- /css/mediaqueries/preferences-reducedData.tentative.https.html [wpt.fyi]:
ERROR- navigator.preferences.reducedData supported:
FAIL - navigator.preferences.reducedData.override supported:
FAIL - navigator.preferences.reducedData.value supported:
FAIL - navigator.preferences.reducedData.validValues supported:
FAIL - navigator.preferences.reducedData.requestOverride() with invalid value throws:
NOTRUN - navigator.preferences.reducedData.clearOverride() supported:
NOTRUN - navigator.preferences.reducedData.requestOverride(null) works like clearOverride():
NOTRUN - navigator.preferences.reducedData.requestOverride('') works like clearOverride():
NOTRUN - navigator.preferences.reducedData.requestOverride() updates (prefers-reduced-data):
NOTRUN - navigator.preferences.reducedData fires change event when requesting override:
FAIL - navigator.preferences.reducedData fires change event when requesting override (without value change):
NOTRUN - navigator.preferences.reducedData fires change event when clearing override:
NOTRUN - navigator.preferences.reducedData fires change event when clearing override (without value change):
NOTRUN
- navigator.preferences.reducedData supported:
- /css/mediaqueries/preferences-reducedMotion.tentative.https.html [wpt.fyi]:
ERROR- navigator.preferences.reducedMotion supported:
FAIL - navigator.preferences.reducedMotion.override supported:
FAIL - navigator.preferences.reducedMotion.value supported:
FAIL - navigator.preferences.reducedMotion.validValues supported:
FAIL - navigator.preferences.reducedMotion.requestOverride() with invalid value throws:
NOTRUN - navigator.preferences.reducedMotion.clearOverride() supported:
NOTRUN - navigator.preferences.reducedMotion.requestOverride(null) works like clearOverride():
NOTRUN - navigator.preferences.reducedMotion.requestOverride('') works like clearOverride():
NOTRUN - navigator.preferences.reducedMotion.requestOverride() updates (prefers-reduced-motion):
NOTRUN - navigator.preferences.reducedMotion fires change event when requesting override:
FAIL - navigator.preferences.reducedMotion fires change event when requesting override (without value change):
NOTRUN - navigator.preferences.reducedMotion fires change event when clearing override:
NOTRUN - navigator.preferences.reducedMotion fires change event when clearing override (without value change):
NOTRUN
- navigator.preferences.reducedMotion supported:
- /css/mediaqueries/preferences-reducedTransparency.tentative.https.html [wpt.fyi]:
ERROR- navigator.preferences.reducedTransparency supported:
FAIL - navigator.preferences.reducedTransparency.override supported:
FAIL - navigator.preferences.reducedTransparency.value supported:
FAIL - navigator.preferences.reducedTransparency.validValues supported:
FAIL - navigator.preferences.reducedTransparency.requestOverride() with invalid value throws:
NOTRUN - navigator.preferences.reducedTransparency.clearOverride() supported:
NOTRUN - navigator.preferences.reducedTransparency.requestOverride(null) works like clearOverride():
NOTRUN - navigator.preferences.reducedTransparency.requestOverride('') works like clearOverride():
NOTRUN - navigator.preferences.reducedTransparency.requestOverride() updates (prefers-reduced-transparency):
NOTRUN - navigator.preferences.reducedTransparency fires change event when requesting override:
FAIL - navigator.preferences.reducedTransparency fires change event when requesting override (without value change):
NOTRUN - navigator.preferences.reducedTransparency fires change event when clearing override:
NOTRUN - navigator.preferences.reducedTransparency fires change event when clearing override (without value change):
NOTRUN
- navigator.preferences.reducedTransparency supported:
- /css/mediaqueries/prefers-reduced-data.html [wpt.fyi]
- Should be known: '(prefers-reduced-data)':
FAIL - Should be known: '(prefers-reduced-data: no-preference)':
FAIL - Should be known: '(prefers-reduced-data: reduce)':
FAIL - Check that no-preference evaluates to false in the boolean context:
FAIL
- Should be known: '(prefers-reduced-data)':
- /css/mediaqueries/resizable.tentative.html [wpt.fyi]
- Should be known: '(resizable: true)':
FAIL - Should be known: '(resizable: false)':
FAIL - Should be known: '(resizable)':
FAIL - Check that resizable evaluates to true in the boolean context:
FAIL
- Should be known: '(resizable: true)':
Comment 4•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fd61aaa8d1cf
https://hg.mozilla.org/mozilla-central/rev/b1aecb72e945
Description
•