2071285 - Experiment with SafeResolve in Streams on all channels

Status: RESOLVED FIXED

(Core :: DOM: Streams, enhancement)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

The Streams API involves a lot of internal Promise uses, where this proposal is expected to be valuable.

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 2071285 - Add Promise::MaybeSafeResolve and use it for Streams r=mgaudet

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b8df7498e43b
https://hg.mozilla.org/integration/autoland/rev/b5ac1b5a6e8f
Add Promise::MaybeSafeResolve and use it for Streams r=mgaudet

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/175bf52313f7
https://hg.mozilla.org/integration/autoland/rev/2d61cb0bb27b
Revert "Bug 2071285 - Add Promise::MaybeSafeResolve and use it for Streams r=mgaudet" for causing build bustages

Comment 4

[Silaghi Andreea]

Backed out for causing build bustages
Backout Link
Push with failures
Failure Log
Failure line Error processing test manifest file /builds/worker/checkouts/gecko/dom/promise/tests/mochitest.toml: Traceback (most recent call last):

Comment 5

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Oopsy!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9779d0c58876
https://hg.mozilla.org/integration/autoland/rev/fbbae8488047
Add Promise::MaybeSafeResolve and use it for Streams r=mgaudet

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fbbae8488047