Closed Bug 2071781 Opened 2 months ago Closed 1 month ago

Use getSitePrincipal in AccessConnectorButton

Categories

(Enterprise Products :: Firefox, defect, P1)

Tracking

(firefox159 verified)

VERIFIED FIXED
Tracking Status
firefox159 --- verified

People

(Reporter: janika, Assigned: jporter)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Bug 2034088 fixed IP Protection resolving the wrong origin on Firefox's built-in viewer pages (PDF/JSON viewer), where the content principal is the internal resource:// origin rather than the http(s) URL in the URL bar. It added getSitePrincipal(gBrowser) in ipprotection-utils.mjs (which builds a principal from gBrowser.currentURI) and switched IPProtectionToolbarButton/Panel to use it.

We need to port the fix to enterprise and let the AccessConnector re-use it.

Josh, my reading is that this could break the built-in viewers, so it's likely S1?

Severity: -- → S1
Flags: needinfo?(joporter)
Priority: -- → P1

It breaks the AccessConnector icon visibility on built-in viewers. Loading the actual content works properly.

I confirmed by adding "https://ipinfo.io/*" to my policy and navigating to https://ipinfo.io/json. I saw the AccessConnector's IP, not my own.

Not sure if you want to reduce severity, but this should be a trivial fix, I can put a patch up soon.

Flags: needinfo?(joporter)

Authored by https://github.com/jporter-dev
https://github.com/mozilla/enterprise-firefox/commit/2e36bed71ac3f4b1cc32f10190571c4a6bd55506
[enterprise-main] Bug 2071781 - Use getSitePrincipal for AccessConnectorButton

Authored by https://github.com/jporter-dev
https://github.com/mozilla/enterprise-firefox/commit/502c91198d7465946d57153ff332ef04d8716082
[enterprise-main] Merge pull request #1565 from jporter-dev/enterprise-bug2071781-use-getsiteprincipal-accessconnectorbutton

(via GitHub webhook, authenticated as shared-secret)

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Flags: qe-verify+
QA Contact: mcurtean

Verified fixed on 159.0a1 (20260930034337), across Win 11, macOS Tahoe 26.4 and Ubuntu.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Blocks: 2078753
Duplicate of this bug: 2078753
Blocks: 2091025
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: