207195 - cannot hide joins/parts in chat window

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[CW Griffin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3.1) Gecko/20030425
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3.1) Gecko/20030425

feature request: I would like to be able to hide joins/parts in the chat window.
 In a very active room (100+ people) the joins and parts being displayed in the
chat window makes a conversation hard to follow.  mIRC calls this feature
'conference mode'.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Koike Kazuhiko]

Attachment: patch v1

Comment 2

[Koike Kazuhiko]

Attachment: patch v2

This patch works with cz0.9.35.

Comment 3

[James Ross]

I've got a basic version working, hiding JOIN, PART and QUIT messages. Is there
anything else for a "conference mode"? Hide nick-changes, perhaps?

Comment 4

[James Ross]

*** Bug 247512 has been marked as a duplicate of this bug. ***

Comment 5

[James Ross]

If anyone wants to do this before I resurect my patch, you need to put the
following into userContent.css:

.msg[msg-type="JOIN"], .msg[msg-type="PART"], .msg[msg-type="QUIT"] { display:
none; }

If you only want to affect a single channel, use this:

.msg[msg-type="JOIN"][msg-dest="#channel"],
.msg[msg-type="PART"][msg-dest="#channel"],
.msg[msg-type="QUIT"][msg-dest="#channel"] { display: none; }

...replacing #channel with the right thing. :)

Comment 6

[James Ross]

Attachment: [checked in] Add conference mode

This patch adds an automatic conference mode (where JOIN, PART, NICK and QUIT
messages are hidden), which uses a preference to determin the user count needed
to trigger it. Default is 50, and to prevent "flapping" it must go at least 10
above or below before it changes. You can force it on or off globally, per
network or per channel by setting the limit to 0 (off/current behaviour) or 1
(on).

Comment 7

[:Gijs (out for now; he/him)]

Comment on attachment 182178 [details] [diff] [review]
[checked in] Add conference mode

Nit:

>@@ -2155,14 +2202,18 @@ function my_cnick (e)
>                              "NICK", "ME!", e.user, this);
>         }
>         this.parent.parent.updateHeader();
>     }
>     else
>     {
>-        this.display(getMsg(MSG_NEWNICK_NOTYOU, [e.oldNick, e.user.unicodeName]),
>-                     "NICK", e.user, this);
>+        if (!this.prefs["conference.enabled"])
>+        {
>+            this.display(getMsg(MSG_NEWNICK_NOTYOU, [e.oldNick,
>+                                                     e.user.unicodeName]),
>+                         "NICK", e.user, this);
>+        }
>     }
> 
>     e.user.updateGraphResource();
>     //this.updateUsers([e.user]);
>     /* updateUsers isn't clever enough (currently) to handle a nick change, so
>      * we fake the user leaving (with the old nick) and coming back (with the

Is there any reason you can't use 'else if' in one block here? Would also save
you from using another line for the display call.

Comment 8

[James Ross]

No reason at all; good catch!

Comment 9

[James Ross]

One thing that is coming up A LOT in #chatzilla is "where are the joins/parts?"
and even weirder stuff like "can ChatZilla display joins/parts?".

For 0.9.68.6 I've made sure the message for when it turns on explains what it is
hiding, and also made it show the explanation EVERY time you join a channel
where it is in effect (since people are great at missing it when it first happens).

rginda, if you could review the existing patch (attachment 182178 [details] [diff] [review]), the heavy
lifting can be landed and the updates I have for 0.9.68.6 can be done as their
own much smaller patch.

Comment 10

[Robert Ginda]

Comment on attachment 182178 [details] [diff] [review]
[checked in] Add conference mode

I think 50 is way to low of a default value.  I'd rather see something more
like 150, myself.  Other than that it looks good to me.  r=rginda.

Comment 11

[James Ross]

Updating whiteboard; this bug needs the patch for always notifying users of the conference state (if it is on) when joining channels, and some other minor tweaks.

Comment 12

[James Ross]

Comment on attachment 182178 [details] [diff] [review]
[checked in] Add conference mode

Clearing r? since patch has already been checked in and was given r beforehand.

Comment 13

[James Ross]

Attachment: Warn user that conf mode is still on

Comment 14

[James Ross]

Last patch checked in --> FIXED (completely).