Open
Bug 2072110
Opened 2 months ago
Updated 2 months ago
Derive NetworkGeolocationProvider's started state from the shutdown AbortController instead of a separate flag
Categories
(Toolkit :: Geolocation Provider, task)
Toolkit
Geolocation Provider
Tracking
()
NEW
People
(Reporter: jstutte, Unassigned)
References
Details
Bug 2071182 gave NetworkGeolocationProvider a provider-level _shutdownController, created in startup() and aborted in shutdown(), so in-flight requests settle right away when the provider is shut down. resetTimer() still guards against re-arming the timer with the separate this.started flag, and startup() / shutdown() keep both in sync by hand.
As suggested in the review of D325308, the flag is now redundant: resetTimer() can check _shutdownController.signal.aborted instead, and startup() / shutdown() can use the same signal for their early-return checks. _shutdownController is null before the first startup(), so the checks need a null guard (or the constructor can create an already-aborted controller).
Updated•2 months ago
|
Severity: -- → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•