2072592 - Happy Eyeballs treats stale negative DNS answers as fresh, so they are never revalidated

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Kershaw Chang [:kershaw]]

HappyEyeballsConnectionAttempt forwards each DNS result to the Rust state machine with a flag indicating whether it came from the stale cache. For successful lookups, it reads the actual value using nsIDNSAddrRecord::GetFromStaleCache or nsIDNSByTypeRecord::GetFromStaleCache. However, for negative, failed, or empty results, it always sets the flag to false.

As a result, a negative response served from the stale cache is incorrectly reported to the state machine as fresh.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 2072592 - Add a grace period for negative DNS cache entries r?#necko

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 2072592 - Forward the stale-cache flag for negative DNS answers to Happy Eyeballs state machine, r=#necko

Depends on D328157

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/529ed25e6d92
https://hg.mozilla.org/integration/autoland/rev/192c57aa765f
Add a grace period for negative DNS cache entries r=necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/7d9725ea0765
https://hg.mozilla.org/integration/autoland/rev/5eb4bd40584f
Forward the stale-cache flag for negative DNS answers to Happy Eyeballs state machine, r=necko-reviewers,valentin

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/192c57aa765f
https://hg.mozilla.org/mozilla-central/rev/5eb4bd40584f