Integrate tracing of buffer edges with existing tracing system
Categories
(Core :: JavaScript: GC, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
(Blocks 1 open bug)
Details
Attachments
(4 external files)
Currently edges to buffer allocators are traced in a different way to edges to GC cells. This bug aims to make these more similar by adding a virtual method to JSTracer which gets called for buffer edges.
| Assignee | ||
Comment 1•2 months ago
|
||
This adds a new virtual method to JSTracer which is called on buffer edges. The
default implementation is to do nothing so most existing tracers are not
affected.
This also changes the signature of TraceBufferEdge to return void like TraceEdge.
| Assignee | ||
Comment 2•2 months ago
|
||
Currently the buffer allocator switches on the tracer kind when tracing a
buffer edge. The patch changes this to use virtual dispatch on the tracer to
decide what to do.
This splits BufferAllocator::TraceEdge into MarkBuffer and PromoteBuffer.
| Assignee | ||
Comment 3•2 months ago
|
||
Currently we call the buffer marking functions when allocating nursery buffers
during GC, to ensure the new buffer survives. This changes things so we set the
marked flag directly when necessary.
| Assignee | ||
Comment 4•2 months ago
|
||
Finally we can rename marking methods that are only used to promote nursery
owned buffers.
Updated•2 months ago
|
Comment 6•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/06c3536ee53f
https://hg.mozilla.org/mozilla-central/rev/465d51b04066
https://hg.mozilla.org/mozilla-central/rev/01da6a89a998
https://hg.mozilla.org/mozilla-central/rev/428690fb684f
Description
•