Shutdown leaks are blamed on the wrong test when a test in the manifest times out
Categories
(Testing :: Mochitest, defect)
Tracking
(firefox158 fixed)
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
When a test in the manifest times out, the leak check runs without the teardown that exists to prevent false positives, so a leak is reported against an earlier test that did not leak.
To reproduce, on a debug build, run browser/extensions/newtab/test/browser/browser_getScreenshots.js followed by a test that deliberately hangs, with a short --timeout.
https://tests.firefox.dev/test.html?test=browser/extensions/newtab/test/browser/browser_getScreenshots.js has several failures caused by this bug.
| Assignee | ||
Comment 1•2 months ago
|
||
browser-test.js releases the resources it keeps alive until shutdown, and
collects twice, before checking for leaks. A test that times out ended the
session without either step, so those resources were blamed on whichever
earlier test created them - hence browser_getScreenshots.js's intermittent
backgroundPageThumbs.xhtml window and docShell leaks.
The release step, the two local collection rounds and the build-type gate are
now shared, which changes what every timing-out browser-chrome test in the tree
does.
Updated•2 months ago
|
Comment 3•1 month ago
|
||
| bugherder | ||
Description
•