2072996 - Incorrect revisions submitted by uplift

Status: NEW

(Conduit :: moz-phab, defect, P3)

Description

[Dave Townsend [:mossop]]

moz-phab version (from moz-phab version): 2.19.0

The uplift docs say that to submit an uplift request you must use moz-phab uplift --train <train> <revision before first of patches to uplift> <last revision of patches to uplift> however when I did this it attempting to include the first revision I passed. I had to list the first revision I wanted to submit instead.

Comment 1

[Connor Sheehan [:sheehan]]

Hm, the behaviour should match moz-phab submit on Git, where revision ranges include the base revision (ie if you're working on a branch mybranch off of origin/autoland, running moz-phab submit origin/autoland mybranch would submit the correct patches).

Any chance you're using Mercurial or jj? For Mercurial I know the revision ranges don't typically include the base revision, perhaps jj is the same.

Comment 2

[Dave Townsend [:mossop]]

I am using jj