browser_context_menu_item.js checks a search shortcut's context menu rather than a top site's
Categories
(Firefox :: New Tab Page, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
browser_context_menu_item.js reaches the menu it inspects with .top-sites-list:not(.search-shortcut, .placeholder). .top-sites-list is the <ul>, and those two classes sit on the .top-site-outer items inside it, so the :not() excludes nothing and the test opens the menu of whichever tile comes first.
The test configures no top sites, so that row holds only the @amazon search shortcut TopSitesFeed pins on its own, followed by the add-shortcut tile. The assertion has therefore only ever inspected a search shortcut's two-item menu, never the top site menu its comment describes.
Narrowing the selector is not enough: the test has to configure the default top sites and address one of them by href.
| Assignee | ||
Comment 1•2 months ago
|
||
test_contextMenuIcons means to inspect a top site's context menu, but its
selector matched the list rather than the tiles inside it, so it has only ever
opened the menu of the search shortcut that was the row's first tile.
Updated•2 months ago
|
Comment 3•1 month ago
|
||
| bugherder | ||
Updated•1 month ago
|
Description
•