"mach try" schedules bootstrap on enterprise
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox158 fixed)
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
(Blocks 1 open bug)
Details
Attachments
(2 external files)
A lot of try pushes have boostrap tasks selected: https://treeherder.mozilla.org/jobs?repo=enterprise-firefox-try&searchStr=bootstrap
I'm not sure if it expected, it sure adds work for nothing?
| Assignee | ||
Comment 1•2 months ago
|
||
[task 2026-09-17T13:01:44.476+00:00] 'base_rev': '0000000000000000000000000000000000000000',
This looks suspicious to me
Comment 2•2 months ago
|
||
The zeroes is what Github uses as a base rev when you push a new branch
Comment 3•2 months ago
|
||
| Assignee | ||
Comment 4•2 months ago
|
||
Github reports a null before revision for a push that creates a branch, which
is what every mach try push to a Git try repository does. GitRepository. get_changed_files turns that into a diff from the empty tree, so files_changed
lists the whole repository and every skip-unless-changed optimization matches.
Tasks that are always-target, such as the ones in the bootstrap kind, are
then scheduled on every try push.
Record the real base in the try_task_config.json parameters at push time, and
derive files_changed only once the parameter overrides have been applied, so
the recorded base is the one used. Decision tasks check out shallow and don't
have that commit, so fetch it first; if it can't be fetched, fall back to the
previous whole-tree behaviour rather than failing the decision task.
Updated•2 months ago
|
Updated•2 months ago
|
Comment 6•1 month ago
|
||
| bugherder | ||
Description
•