Closed Bug 2073031 Opened 2 months ago Closed 1 month ago

"mach try" schedules bootstrap on enterprise

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox158 fixed)

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

(Blocks 1 open bug)

Details

Attachments

(2 external files)

A lot of try pushes have boostrap tasks selected: https://treeherder.mozilla.org/jobs?repo=enterprise-firefox-try&searchStr=bootstrap

I'm not sure if it expected, it sure adds work for nothing?

https://treeherder.mozilla.org/logviewer?job_id=593595155&repo=enterprise-firefox-try&task=EElUsofSQHW4L3LLgqxfuw.0&lineNumber=123

[task 2026-09-17T13:01:44.476+00:00]   'base_rev': '0000000000000000000000000000000000000000',

This looks suspicious to me

The zeroes is what Github uses as a base rev when you push a new branch

Github reports a null before revision for a push that creates a branch, which
is what every mach try push to a Git try repository does. GitRepository. get_changed_files turns that into a diff from the empty tree, so files_changed
lists the whole repository and every skip-unless-changed optimization matches.
Tasks that are always-target, such as the ones in the bootstrap kind, are
then scheduled on every try push.

Record the real base in the try_task_config.json parameters at push time, and
derive files_changed only once the parameter overrides have been applied, so
the recorded base is the one used. Decision tasks check out shallow and don't
have that commit, so fetch it first; if it can't be fetched, fall back to the
previous whole-tree behaviour rather than failing the decision task.

Assignee: nobody → lissyx+mozillians
Status: NEW → ASSIGNED
Component: Firefox → Task Configuration
Product: Enterprise Products → Firefox Build System
Pushed by alissy@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b0e9a082fd28 https://hg.mozilla.org/integration/autoland/rev/0231825b71f2 Record the try push base revision so the decision task can diff against it r=taskgraph-reviewers,ahal
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
See Also: → 2072920
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: