Closed Bug 2073213 Opened 2 months ago Closed 1 month ago

Assertion failure: Storage<T>::initialized(), at /builds/worker/workspace/obj-build/dist/include/mozilla/ThreadLocal.h:223

Categories

(Core :: JavaScript Engine, defect, P3)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
159 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox-esr153 --- unaffected
firefox156 --- unaffected
firefox157 --- disabled
firefox158 --- disabled
firefox159 --- fixed

People

(Reporter: tsmith, Assigned: RyanVM)

References

(Blocks 2 open bugs, Regression, )

Details

(Keywords: assertion, regression)

Attachments

(1 external file)

Found with m-c 20260910-23480a99840e (--enable-debug)

This was found by visiting a live website with a debug build.

STR:

  • Launch browser and visit site

This issue was triggered by visiting http://www.le-sportif.com/.

Assertion failure: Storage<T>::initialized(), at /builds/worker/workspace/obj-build/dist/include/mozilla/ThreadLocal.h:223

14|0|libxul.so|js::AutoUnsafeCallWithABI::AutoUnsafeCallWithABI(js::UnsafeABIStrictness)|git:github.com/mozilla-firefox/firefox:js/src/vm/JSContext.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1661|0xec
14|1|libxul.so|FoldBinaryArithmetic(FoldInfo, js::frontend::ParseNode**)|git:github.com/mozilla-firefox/firefox:js/src/frontend/FoldConstants.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1046|0x2e7
14|2|libxul.so|FoldVisitor::visitDivExpr(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/FoldConstants.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1382|0x5f
14|3|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0xe30
14|4|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitOrExpr(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x9a
14|5|libxul.so|FoldVisitor::visitOrExpr(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/FoldConstants.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1416|0x11
14|6|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x9ad
14|7|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitArguments(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x9a
14|8|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0xa3
14|9|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x7e
14|10|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitExpressionStmt(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x4d
14|11|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x47b
14|12|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitStatementList(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x9a
14|13|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x14e3
14|14|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0xf6b
14|15|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitParamsBody(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x8a
14|16|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x54d
14|17|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitFunction(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x56
14|18|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x49e
14|19|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitOrExpr(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x9a
14|20|libxul.so|FoldVisitor::visitOrExpr(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/FoldConstants.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1416|0x11
14|21|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x9ad
14|22|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitReturnStmt(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x4d
14|23|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x15d8
14|24|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitStatementList(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x9a
14|25|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x14e3
14|26|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0xf6b
14|27|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitParamsBody(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x8a
14|28|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x54d
14|29|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitFunction(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x56
14|30|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x49e
14|31|libxul.so|FoldVisitor::internalVisitCall(js::frontend::BinaryNode*)|git:github.com/mozilla-firefox/firefox:js/src/frontend/FoldConstants.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1455|0x8a
14|32|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x7e
14|33|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitAssignExpr(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x54
14|34|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0xb0b
14|35|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitVarStmt(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x8a
14|36|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x13a8
14|37|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitStatementList(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x9a
14|38|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x14e3
14|39|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0xf6b
14|40|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitParamsBody(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x8a
14|41|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x54d
14|42|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitFunction(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x56
14|43|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x49e
14|44|libxul.so|FoldVisitor::internalVisitCall(js::frontend::BinaryNode*)|git:github.com/mozilla-firefox/firefox:js/src/frontend/FoldConstants.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1455|0x8a
14|45|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x7e
14|46|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitExpressionStmt(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x4d
14|47|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x47b
14|48|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visitStatementList(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|127|0x9a
14|49|libxul.so|js::frontend::RewritingParseNodeVisitor<FoldVisitor>::visit(js::frontend::ParseNode*&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/ParseNodeVisitor.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|113|0x14e3
14|50|libxul.so|js::frontend::FoldConstants(js::FrontendContext*, js::frontend::ParserAtomsTable&, mozilla::Vector<js::frontend::BigIntStencil, (unsigned long)0, js::SystemAllocPolicy>&, js::frontend::ParseNode**, js::frontend::FullParseHandler*)|git:github.com/mozilla-firefox/firefox:js/src/frontend/FoldConstants.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1589|0x3a
14|51|libxul.so|js::frontend::Parser<js::frontend::FullParseHandler, mozilla::Utf8Unit>::globalBody(js::frontend::GlobalSharedContext*)|git:github.com/mozilla-firefox/firefox:js/src/frontend/Parser.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1843|0x228
14|52|libxul.so|ScriptCompiler<mozilla::Utf8Unit>::compile(JSContext*, js::frontend::SharedContext*)|git:github.com/mozilla-firefox/firefox:js/src/frontend/BytecodeCompiler.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|963|0xf3
14|53|libxul.so|CompileGlobalScriptToStencilAndMaybeInstantiate<mozilla::Utf8Unit>(JSContext*, js::FrontendContext*, js::LifoAlloc&, js::frontend::CompilationInput&, js::frontend::ScopeBindingCache*, JS::SourceText<mozilla::Utf8Unit>&, js::ScopeKind, mozilla::Vector<js::frontend::ExtraBindingInfo, (unsigned long)0, js::SystemAllocPolicy>*, js::frontend::CompilationStencil**, js::frontend::InitialStencilAndDelazifications**, js::frontend::CompilationGCOutput*)|git:github.com/mozilla-firefox/firefox:js/src/frontend/BytecodeCompiler.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|338|0x2d2
14|54|libxul.so|JS::CompileGlobalScriptToStencil(js::FrontendContext*, JS::ReadOnlyCompileOptions const&, JS::SourceText<mozilla::Utf8Unit>&)|git:github.com/mozilla-firefox/firefox:js/src/frontend/BytecodeCompiler.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|432|0x179
14|55|libxul.so|mozilla::dom::JSValidatorChild::ShouldAllowJS(mozilla::Span<char const, (unsigned long)18446744073709551615> const&) const|git:github.com/mozilla-firefox/firefox:dom/ipc/JSValidatorChild.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|206|0x18f
14|56|libxul.so|mozilla::dom::JSValidatorChild::RecvOnStopRequest(nsresult const&, nsTSubstring<char> const&, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&)|git:github.com/mozilla-firefox/firefox:dom/ipc/JSValidatorChild.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|114|0x14e
14|57|libxul.so|mozilla::dom::PJSValidatorChild::OnMessageReceived(IPC::Message const&)|s3:gecko-generated-sources:ed7f61b89e113f1c8a58e05af3b5fc39b9720596f16bc5d669df900990173c84cfba5997ef0e91062354ace7af548a9c3c768210f5c3e68477054f5194ed440d/ipc/ipdl/PJSValidatorChild.cpp:|269|0x888
14|58|libxul.so|mozilla::dom::PJSOracleChild::OnMessageReceived(IPC::Message const&)|s3:gecko-generated-sources:33876316ed69f1130fec9b8e953459e3fdd0312181496bddc45e36cffeb12d9cbdc959497bde23bf2e47736ae0582e54ce5a317292d74f1818c72dbe6edf62ce/ipc/ipdl/PJSOracleChild.cpp:|161|0x2f8
14|59|libxul.so|mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&)|git:github.com/mozilla-firefox/firefox:ipc/glue/MessageChannel.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1797|0x128
14|60|libxul.so|mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, std::__ndk1::unique_ptr<IPC::Message, std::__ndk1::default_delete<IPC::Message> >)|git:github.com/mozilla-firefox/firefox:ipc/glue/MessageChannel.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1723|0x239
14|61|libxul.so|mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&)|git:github.com/mozilla-firefox/firefox:ipc/glue/MessageChannel.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1512|0x166
14|62|libxul.so|mozilla::ipc::MessageChannel::MessageTask::Run()|git:github.com/mozilla-firefox/firefox:ipc/glue/MessageChannel.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1614|0xcd
14|63|libxul.so|mozilla::RunnableTask::Run()|git:github.com/mozilla-firefox/firefox:xpcom/threads/TaskController.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|721|0x17
14|64|libxul.so|mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&)|git:github.com/mozilla-firefox/firefox:xpcom/threads/TaskController.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1367|0x599
14|65|libxul.so|mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&)|git:github.com/mozilla-firefox/firefox:xpcom/threads/TaskController.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1190|0x57
14|66|libxul.so|mozilla::TaskController::ProcessPendingMTTask(bool)|git:github.com/mozilla-firefox/firefox:xpcom/threads/TaskController.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|657|0x65
14|67|libxul.so|mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_0>::Run()|git:github.com/mozilla-firefox/firefox:xpcom/threads/nsThreadUtils.h:e3285238626d45d2ec7ee8941fc1c49615730ba5|535|0x16
14|68|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|git:github.com/mozilla-firefox/firefox:xpcom/threads/nsThread.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|1319|0x5ca
14|69|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|git:github.com/mozilla-firefox/firefox:xpcom/threads/nsThreadUtils.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|471|0x4f
14|70|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|git:github.com/mozilla-firefox/firefox:ipc/glue/MessagePump.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|83|0xb0
14|71|libxul.so|MessageLoop::Run()|git:github.com/mozilla-firefox/firefox:ipc/chromium/src/base/message_loop.cc:e3285238626d45d2ec7ee8941fc1c49615730ba5|346|0x61
14|72|libxul.so|nsBaseAppShell::Run()|git:github.com/mozilla-firefox/firefox:widget/nsBaseAppShell.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|151|0x28
14|73|libxul.so|XRE_RunAppShell()|git:github.com/mozilla-firefox/firefox:toolkit/xre/nsEmbedFunctions.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|644|0x6b
14|74|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|git:github.com/mozilla-firefox/firefox:ipc/glue/MessagePump.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|233|0x3c
14|75|libxul.so|MessageLoop::Run()|git:github.com/mozilla-firefox/firefox:ipc/chromium/src/base/message_loop.cc:e3285238626d45d2ec7ee8941fc1c49615730ba5|346|0x61
14|76|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|git:github.com/mozilla-firefox/firefox:toolkit/xre/nsEmbedFunctions.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|582|0x796
14|77|libmozglue.so|Java_org_mozilla_gecko_mozglue_GeckoLoader_nativeRun|git:github.com/mozilla-firefox/firefox:mozglue/android/APKOpen.cpp:e3285238626d45d2ec7ee8941fc1c49615730ba5|472|0x2e9

Looks like a regression from ORB.

Keywords: regression
Regressed by: orb
Severity: -- → S3
Priority: -- → P3

since bug 1532642 is a meta bug, i think maybe bug 2070565 was the meant regressor

Blocks: orb
Flags: needinfo?(afarre)
Regressed by: 2070565
No longer regressed by: orb

Set release status flags based on info from the regressing bug 2070565

The ORB JS validator (utility process) compiles scripts through the frontend-only API. JS_FrontendOnlyInit never initializes TlsContext. Constant folding of / and % calls NumberDiv/NumberMod (util/PortableMath.h). Those functions contain an AutoUnsafeCallWithABI, whose constructor called TlsContext.get() unconditionally. On platforms that use pthread-key TLS storage (Android, because of MOZ_LINKER), that triggers Assertion failure: Storage<T>::initialized(). Platforms with native TLS just get nullptr.

Fix: in AutoUnsafeCallWithABI, treat an uninitialized TlsContext like the existing "no JSContext" case, which is the helper-thread path. This matches what JS::AutoAssertNoGC already does. The change is at the guard level rather than in the frontend, so any other ABI helper reused from frontend-only code is covered too. The code is only compiled under JS_CHECK_UNSAFE_CALL_WITH_ABI (debug builds), so release builds pay no performance cost.

Does this look sane, Arai?

Flags: needinfo?(arai.unmht)

This is debug-only code, and thus this affects nothing on non-debug build.

For this specific bug, the attached patch makes sense.

Then, in a followup bug, we can rework the ORB side not to perform the full compilation.
The goal there is to verify that the given buffer is valid JavaScript, which means, what we need is only parsing,
and anything after that step (constant folding, bytecode compilation) are unnecessary.

Flags: needinfo?(arai.unmht)
Flags: needinfo?(afarre)
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Pushed by rvandermeulen@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fbb7d3939441 https://hg.mozilla.org/integration/autoland/rev/8968bab7be2b Don't assert on uninitialized TlsContext in AutoUnsafeCallWithABI for frontend-only users r=arai
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
QA Whiteboard: [qa-triage-done-c160/b159]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: