Open Bug 2073301 Opened 2 months ago Updated 2 months ago

`moz-phab submit` calls 'git gc' multiple times per run

Categories

(Conduit :: moz-phab, defect, P3)

Tracking

(Not tracked)

People

(Reporter: marco, Unassigned)

Details

(Keywords: good-first-bug)

Do we actually need to call git gc twice? Do we actually need it at all since it's automatically done periodically by git?

https://github.com/mozilla-conduit/review/blob/2e09bab069f2a861f9c1b60357d77b4580bb9911/tests/test_git_call_counts.py#L199

We definitely don't need to call it twice. Looks like we call repo.cleanup() explicitly at the end of submit, and also in the general command harness, so it's not intentional.

I agree, moz-phab doesn't need to call it at all.

Type: enhancement → defect
Keywords: good-first-bug
Priority: -- → P3
Summary: Make `moz-phab submit` call 'git gc' only once → `moz-phab submit` calls 'git gc' multiple times per run
You need to log in before you can comment on or make changes to this bug.