Closed Bug 2073321 Opened 2 months ago Closed 1 month ago

upgrade jxl-rs to 0.7.4

Categories

(Core :: Graphics: ImageLib, task)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(3 external files)

No description provided.

Plain ./mach vendor rust.

This re-applies the bug 2043090 macOS x86_64 workaround.

jxl_simd's src/x86_64/avx.rs and avx512.rs are byte-identical between 0.7.3
and 0.7.4, so the workaround forward-ports with no adaptation.

Is the bug 2043090 workaround still needed now that rust 1.95 is used? See also bug 2043091

We use 1.95 in CI to produce our official builds but our MSRV is currently 1.90

https://searchfox.org/firefox-main/rev/572cbc53633d3ed8a0b1390828611752f0317938/Cargo.toml#158

so anyone can build with the affected versions until 1.95 is our minimum. I don't want to leave a huge 3x performance cliff around.

Duplicate of this bug: 2073801
Pushed by tnikkel@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/84902c385afa https://hg.mozilla.org/integration/autoland/rev/bad96908482f Back out the local jxl_simd workaround so the 0.7.4 vendor bump is a pure upstream delta. r=supply-chain-reviewers,gfx-reviewers,bhood,lsalzman https://github.com/mozilla-firefox/firefox/commit/3e56a21d3661 https://hg.mozilla.org/integration/autoland/rev/9ceff09b8e79 Upgrade jxl-rs to 0.7.4. r=supply-chain-reviewers,gfx-reviewers,bhood,lsalzman https://github.com/mozilla-firefox/firefox/commit/20733b91be18 https://hg.mozilla.org/integration/autoland/rev/9bdcc91f3230 Reapply the jxl_simd macOS x86_64 workaround on top of 0.7.4. r=supply-chain-reviewers,gfx-reviewers,bhood,lsalzman
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
QA Whiteboard: [qa-triage-done-c159/b158]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: